[PR #3982] [MERGED] refactor: infra-config code refactor #4622

New issue

Closed

opened 2026-03-17 02:08:34 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:08:34 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3982
Author: @mirarifhasan
Created: 4/17/2024
Status: ✅ Merged
Merged: 4/19/2024
Merged by: @balub

Base: release/2024.3.1 ← Head: maintenance/backend

📝 Commits (6)

6517c44 chore: add getMissingInfraConfigEntries to avoid code duplication
eaa6f10 feat: isServiceConfigured modified
f694177 docs: add missing function doc
b99f3c5 feat: argon2 version updated and removed types-argon2 depricated package
21feec5 Revert "feat: argon2 version updated and removed types-argon2 depricated package"
5cfe155 Revert "feat: isServiceConfigured modified"

📊 Changes

2 files changed (+28 additions, -15 deletions)

View changed files

📝 packages/hoppscotch-backend/src/infra-config/helper.ts (+20 -6)
📝 packages/hoppscotch-backend/src/infra-config/infra-config.service.ts (+8 -9)

📄 Description

Closes HSB-389

Description

This PR reflects the following things:

Code refactor -> Infra Config Module

initializeInfraConfigTable and isInfraConfigTablePopulated has code duplication
isServiceConfigured reduce the manual key

Checks

My pull request adheres to the code style of this project
My code requires changes to the documentation
I have updated the documentation as required
All the tests have passed

Additional Information

Nil

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3982 **Author:** [@mirarifhasan](https://github.com/mirarifhasan) **Created:** 4/17/2024 **Status:** ✅ Merged **Merged:** 4/19/2024 **Merged by:** [@balub](https://github.com/balub) **Base:** `release/2024.3.1` ← **Head:** `maintenance/backend` --- ### 📝 Commits (6) - [`6517c44`](https://github.com/hoppscotch/hoppscotch/commit/6517c444e8cd19b0b8802d43525cd24bd89d8014) chore: add getMissingInfraConfigEntries to avoid code duplication - [`eaa6f10`](https://github.com/hoppscotch/hoppscotch/commit/eaa6f105bbed494de72cea472043b825bee2e206) feat: isServiceConfigured modified - [`f694177`](https://github.com/hoppscotch/hoppscotch/commit/f69417747bc0b0d28467ee4d3be29713afbfc4a4) docs: add missing function doc - [`b99f3c5`](https://github.com/hoppscotch/hoppscotch/commit/b99f3c5aaea0bec3701bd6f81c105b490f9aaa55) feat: argon2 version updated and removed types-argon2 depricated package - [`21feec5`](https://github.com/hoppscotch/hoppscotch/commit/21feec5ff6159a189ac2f15150820cca5f4f1ba7) Revert "feat: argon2 version updated and removed types-argon2 depricated package" - [`5cfe155`](https://github.com/hoppscotch/hoppscotch/commit/5cfe1558c69abd881dafd41b10476fcbc9004be6) Revert "feat: isServiceConfigured modified" ### 📊 Changes **2 files changed** (+28 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-backend/src/infra-config/helper.ts` (+20 -6) 📝 `packages/hoppscotch-backend/src/infra-config/infra-config.service.ts` (+8 -9) </details> ### 📄 Description    Closes HSB-389 ### Description  This PR reflects the following things: Code refactor -> Infra Config Module - [x] `initializeInfraConfigTable` and `isInfraConfigTablePopulated` has code duplication - [x] `isServiceConfigured` reduce the manual key  ### Checks  - [x] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [ ] I have updated the documentation as required - [x] All the tests have passed ### Additional Information  Nil --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>