[PR #3939] [MERGED] fix(desktop): set window caption color if Windows version >= 11 #4606

New issue

Closed

opened 2026-03-17 02:07:45 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:07:45 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3939
Author: @Timic3
Created: 3/27/2024
Status: ✅ Merged
Merged: 4/16/2024
Merged by: @AndrewBastin

Base: release/2024.3.1 ← Head: fix/desktop-win10-crash

📝 Commits (2)

8deffb3 fix(desktop): set window caption color if Windows version >= 11
54db943 chore(desktop): use winver crate to detect Windows version

📊 Changes

3 files changed (+29 additions, -9 deletions)

View changed files

📝 packages/hoppscotch-selfhost-desktop/src-tauri/Cargo.lock (+10 -0)
📝 packages/hoppscotch-selfhost-desktop/src-tauri/Cargo.toml (+1 -0)
📝 packages/hoppscotch-selfhost-desktop/src-tauri/src/win/window.rs (+18 -9)

📄 Description

Closes #3524

Description

This pull request fixes Windows 10 crash when application is opened. It happened due to DWMWA_CAPTION_COLOR being available only on Windows 11 (build number 22000) and up (see here). This is fixed by checking Windows version number and build, however it is also fixable by just catching the error, but it's probably best not to fill Windows event log with errors.

Checks

My pull request adheres to the code style of this project
All the tests have passed

Additional Information

I haven't tested this on Windows 11 yet, however feel free to test it.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3939 **Author:** [@Timic3](https://github.com/Timic3) **Created:** 3/27/2024 **Status:** ✅ Merged **Merged:** 4/16/2024 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `release/2024.3.1` ← **Head:** `fix/desktop-win10-crash` --- ### 📝 Commits (2) - [`8deffb3`](https://github.com/hoppscotch/hoppscotch/commit/8deffb38b3faef6b73fbc595dd7148b1b745a5c9) fix(desktop): set window caption color if Windows version >= 11 - [`54db943`](https://github.com/hoppscotch/hoppscotch/commit/54db943ce3963632e306800c37f4bcf0c44dc1c0) chore(desktop): use winver crate to detect Windows version ### 📊 Changes **3 files changed** (+29 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-selfhost-desktop/src-tauri/Cargo.lock` (+10 -0) 📝 `packages/hoppscotch-selfhost-desktop/src-tauri/Cargo.toml` (+1 -0) 📝 `packages/hoppscotch-selfhost-desktop/src-tauri/src/win/window.rs` (+18 -9) </details> ### 📄 Description   Closes #3524  ### Description  This pull request fixes Windows 10 crash when application is opened. It happened due to `DWMWA_CAPTION_COLOR` being available only on Windows 11 (build number 22000) and up (see [here](https://learn.microsoft.com/en-us/windows/win32/api/dwmapi/ne-dwmapi-dwmwindowattribute)). This is fixed by checking Windows version number and build, however it is also fixable by just catching the error, but it's probably best not to fill Windows event log with errors.  ### Checks  - [x] My pull request adheres to the code style of this project - [ ] All the tests have passed ### Additional Information  I haven't tested this on Windows 11 yet, however feel free to test it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>