[PR #3934] [MERGED] fix: lint errors removed by using `satisfies` or `as` for type #4604

New issue

Closed

opened 2026-03-17 02:07:29 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:07:29 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3934
Author: @anwarulislam
Created: 3/25/2024
Status: ✅ Merged
Merged: 3/28/2024
Merged by: @AndrewBastin

Base: release/2024.3.0 ← Head: fix/lint-errors

📝 Commits (5)

39b9f2f fix: lint errors
0fb4644 chore: resolve type errors
8a1f0e9 chore: disable jsx in typescript config
69b41c9 chore: disable jsx in eslint config for selfhost-web
ae7cdfa fix: proper type for vue files

📊 Changes

11 files changed (+526 additions, -83 deletions)

View changed files

📝 packages/hoppscotch-common/.eslintrc.js (+3 -0)
📝 packages/hoppscotch-common/package.json (+6 -6)
📝 packages/hoppscotch-common/src/components/collections/Properties.vue (+26 -16)
📝 packages/hoppscotch-common/src/components/collections/graphql/index.vue (+11 -7)
📝 packages/hoppscotch-common/src/components/collections/index.vue (+3 -6)
📝 packages/hoppscotch-common/src/components/graphql/Authorization.vue (+1 -1)
📝 packages/hoppscotch-common/src/components/http/Authorization.vue (+1 -1)
📝 packages/hoppscotch-common/src/components/http/OAuth2Authorization.vue (+8 -6)
📝 packages/hoppscotch-common/src/pages/oauth.vue (+5 -4)
📝 packages/hoppscotch-selfhost-web/.eslintrc.cjs (+3 -0)
📝 pnpm-lock.yaml (+459 -36)

📄 Description

Description

Using satisfies or as for type enforcement to skip lint errors.

Before	After

Not Completed
Completed

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3934 **Author:** [@anwarulislam](https://github.com/anwarulislam) **Created:** 3/25/2024 **Status:** ✅ Merged **Merged:** 3/28/2024 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `release/2024.3.0` ← **Head:** `fix/lint-errors` --- ### 📝 Commits (5) - [`39b9f2f`](https://github.com/hoppscotch/hoppscotch/commit/39b9f2f1158ecd67d78a0e72a082feeaeb0170ae) fix: lint errors - [`0fb4644`](https://github.com/hoppscotch/hoppscotch/commit/0fb4644e3bebdbd3ad98979c47151f305f9936ae) chore: resolve type errors - [`8a1f0e9`](https://github.com/hoppscotch/hoppscotch/commit/8a1f0e9ff4d984b07d5c88db36f3c6c64fce71d8) chore: disable jsx in typescript config - [`69b41c9`](https://github.com/hoppscotch/hoppscotch/commit/69b41c9e6135307fb4b0dabfbc44f9d57606d568) chore: disable jsx in eslint config for selfhost-web - [`ae7cdfa`](https://github.com/hoppscotch/hoppscotch/commit/ae7cdfa1561c8532b9f06b2ea8cc318b5cb7f55b) fix: proper type for vue files ### 📊 Changes **11 files changed** (+526 additions, -83 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/.eslintrc.js` (+3 -0) 📝 `packages/hoppscotch-common/package.json` (+6 -6) 📝 `packages/hoppscotch-common/src/components/collections/Properties.vue` (+26 -16) 📝 `packages/hoppscotch-common/src/components/collections/graphql/index.vue` (+11 -7) 📝 `packages/hoppscotch-common/src/components/collections/index.vue` (+3 -6) 📝 `packages/hoppscotch-common/src/components/graphql/Authorization.vue` (+1 -1) 📝 `packages/hoppscotch-common/src/components/http/Authorization.vue` (+1 -1) 📝 `packages/hoppscotch-common/src/components/http/OAuth2Authorization.vue` (+8 -6) 📝 `packages/hoppscotch-common/src/pages/oauth.vue` (+5 -4) 📝 `packages/hoppscotch-selfhost-web/.eslintrc.cjs` (+3 -0) 📝 `pnpm-lock.yaml` (+459 -36) </details> ### 📄 Description ### Description Using `satisfies` or `as` for type enforcement to skip lint errors. | Before | After | |--------|-------| | <img width="356" alt="image" src="https://github.com/hoppscotch/hoppscotch/assets/26295990/f61a0b55-cba8-452a-8210-6e7eb3212b50"> | <img width="394" alt="image" src="https://github.com/hoppscotch/hoppscotch/assets/26295990/371a3195-fb96-490c-83f4-62cf8888f01b"> - [ ] Not Completed - [x] Completed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>