[PR #3931] [MERGED] fix(common): ensure requests are translated to the latest version during import and search actions #4602

New issue

Closed

opened 2026-03-17 02:07:29 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:07:29 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3931
Author: @jamesgeorge007
Created: 3/22/2024
Status: ✅ Merged
Merged: 3/25/2024
Merged by: @jamesgeorge007

Base: release/2024.3.0 ← Head: hotfix/versioned-entities

📝 Commits (3)

a0bf684 fix: ensure requests within imported collections are translated to the latest version
c8017aa fix: ensure requests within search results are translated to the latest version
1592147 fix: use the correct versioned entity for validating GQL requests

📊 Changes

2 files changed (+69 additions, -20 deletions)

View changed files

📝 packages/hoppscotch-common/src/helpers/import-export/import/hopp.ts (+47 -12)
📝 packages/hoppscotch-common/src/helpers/teams/TeamsSearch.service.ts (+22 -8)

📄 Description

Description

This PR ensures requests are validated against the HoppRESTRequest versioned entity and translated to the latest version before consuming preventing any exceptions under the following scenarios.

Importing a collection with requests conforming to an old schema followed by an attempt to open one among them via spotlight.
Searching for a request in the collection tree with the above state (one or more requests not as per the latest schema) and selecting the request from the search results.

Fixes HFE-461.

Checks

My pull request adheres to the code style of this project
All the tests have passed

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3931 **Author:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Created:** 3/22/2024 **Status:** ✅ Merged **Merged:** 3/25/2024 **Merged by:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Base:** `release/2024.3.0` ← **Head:** `hotfix/versioned-entities` --- ### 📝 Commits (3) - [`a0bf684`](https://github.com/hoppscotch/hoppscotch/commit/a0bf684fc985f6c19ef21c344dc7c3e08bdbbb3e) fix: ensure requests within imported collections are translated to the latest version - [`c8017aa`](https://github.com/hoppscotch/hoppscotch/commit/c8017aa7a3fa17217deff346084aed4bca556558) fix: ensure requests within search results are translated to the latest version - [`1592147`](https://github.com/hoppscotch/hoppscotch/commit/1592147005db36bd02de2f54fc7994f84bc37cfc) fix: use the correct versioned entity for validating GQL requests ### 📊 Changes **2 files changed** (+69 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/helpers/import-export/import/hopp.ts` (+47 -12) 📝 `packages/hoppscotch-common/src/helpers/teams/TeamsSearch.service.ts` (+22 -8) </details> ### 📄 Description ### Description This PR ensures requests are validated against the `HoppRESTRequest` versioned entity and translated to the latest version before consuming preventing any exceptions under the following scenarios. - Importing a collection with requests conforming to an old schema followed by an attempt to open one among them via spotlight. - Searching for a request in the collection tree with the above state (one or more requests not as per the latest schema) and selecting the request from the search results. Fixes HFE-461. ### Checks - [x] My pull request adheres to the code style of this project - [x] All the tests have passed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>