[PR #3925] [MERGED] fix: workspace list section bugs #4600

New issue

Closed

opened 2026-03-17 02:07:12 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:07:12 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3925
Author: @nivedin
Created: 3/21/2024
Status: ✅ Merged
Merged: 3/22/2024
Merged by: @jamesgeorge007

Base: release/2024.3.0 ← Head: fix/team-list-section-bugs

📝 Commits (3)

8f33dac fix: add loading state and switch workspace when current workspace is deleted
38b2795 refactor: close modal after resolve and remove spinner in team card
ebc18d0 chore: close the confirmation modal if the team deletion attempt fails

📊 Changes

2 files changed (+28 additions, -7 deletions)

View changed files

📝 packages/hoppscotch-common/src/components/teams/Team.vue (+25 -0)
📝 packages/hoppscotch-common/src/components/teams/index.vue (+3 -7)

📄 Description

Closes HFE-458

Description

This PR fixes the bugs in workspace section in profile page

Add loading spinner while deleting a workspace
Refetch workspace list after deleting a workspace rather waiting for the workspace list fetch poll to effect the list
Switch to personal workspace if the current selected workspace is same as that deleted.

Checks

My pull request adheres to the code style of this project
My code requires changes to the documentation
I have updated the documentation as required
All the tests have passed

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3925 **Author:** [@nivedin](https://github.com/nivedin) **Created:** 3/21/2024 **Status:** ✅ Merged **Merged:** 3/22/2024 **Merged by:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Base:** `release/2024.3.0` ← **Head:** `fix/team-list-section-bugs` --- ### 📝 Commits (3) - [`8f33dac`](https://github.com/hoppscotch/hoppscotch/commit/8f33dac0a647291c2589512659af9d9f7200266c) fix: add loading state and switch workspace when current workspace is deleted - [`38b2795`](https://github.com/hoppscotch/hoppscotch/commit/38b2795eed1d771cebacbb54072864f283dea384) refactor: close modal after resolve and remove spinner in team card - [`ebc18d0`](https://github.com/hoppscotch/hoppscotch/commit/ebc18d005c0143309c001eab886d451b2f3edcee) chore: close the confirmation modal if the team deletion attempt fails ### 📊 Changes **2 files changed** (+28 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/components/teams/Team.vue` (+25 -0) 📝 `packages/hoppscotch-common/src/components/teams/index.vue` (+3 -7) </details> ### 📄 Description Closes HFE-458 ### Description This PR fixes the bugs in workspace section in profile page - Add loading spinner while deleting a workspace - Refetch workspace list after deleting a workspace rather waiting for the workspace list fetch poll to effect the list - Switch to personal workspace if the current selected workspace is same as that deleted. ### Checks - [x] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [ ] I have updated the documentation as required - [x] All the tests have passed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>