[PR #3927] [MERGED] chore: split axios request options into platform #4596

New issue

Closed

opened 2026-03-17 02:07:12 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:07:12 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3927
Author: @amk-dev
Created: 3/21/2024
Status: ✅ Merged
Merged: 3/22/2024
Merged by: @jamesgeorge007

Base: release/2024.3.0 ← Head: fix/use-backend-headers

📝 Commits (3)

7f91429 fix: use getBackendHeaders from platform to add credentials for central
b1139ac chore: split axios options to platform
501aad3 chore: cleanup

📊 Changes

3 files changed (+21 additions, -3 deletions)

View changed files

📝 packages/hoppscotch-common/src/helpers/teams/TeamsSearch.service.ts (+4 -3)
📝 packages/hoppscotch-common/src/platform/auth.ts (+10 -0)
📝 packages/hoppscotch-selfhost-web/src/platform/auth/auth.platform.ts (+7 -0)

📄 Description

Changes

This PR introduces a new property axiosPlatformConfig to auth platform definition. this allows us to pass different axios configs based on the platform.

eg: Central uses Bearer Token to authenticate with the backend, while the SH uses Cookies, the configs for these can now belong in the respective platforms.

we already do this for our Gql Client, this PR adds the same for axios configs to be used for requests sent outside of the graphql client.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3927 **Author:** [@amk-dev](https://github.com/amk-dev) **Created:** 3/21/2024 **Status:** ✅ Merged **Merged:** 3/22/2024 **Merged by:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Base:** `release/2024.3.0` ← **Head:** `fix/use-backend-headers` --- ### 📝 Commits (3) - [`7f91429`](https://github.com/hoppscotch/hoppscotch/commit/7f91429818b2d6b05e771790bd78a4cbff532de4) fix: use getBackendHeaders from platform to add credentials for central - [`b1139ac`](https://github.com/hoppscotch/hoppscotch/commit/b1139ac482aca633ab4b2f189bf4dc29bc10b267) chore: split axios options to platform - [`501aad3`](https://github.com/hoppscotch/hoppscotch/commit/501aad3417810d73c7e402bdb0da6762536e3777) chore: cleanup ### 📊 Changes **3 files changed** (+21 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/helpers/teams/TeamsSearch.service.ts` (+4 -3) 📝 `packages/hoppscotch-common/src/platform/auth.ts` (+10 -0) 📝 `packages/hoppscotch-selfhost-web/src/platform/auth/auth.platform.ts` (+7 -0) </details> ### 📄 Description **Changes** This PR introduces a new property `axiosPlatformConfig` to auth platform definition. this allows us to pass different axios configs based on the platform. eg: Central uses Bearer Token to authenticate with the backend, while the SH uses Cookies, the configs for these can now belong in the respective platforms. we already do this for our Gql Client, this PR adds the same for axios configs to be used for requests sent outside of the graphql client. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>