[PR #3917] [MERGED] fix(common): prevent exception with `ShortcodeListAdapter` initialization #4589

New issue

Closed

opened 2026-03-17 02:06:40 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:06:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3917
Author: @jamesgeorge007
Created: 3/20/2024
Status: ✅ Merged
Merged: 3/20/2024
Merged by: @AndrewBastin

Base: release/2024.3.0 ← Head: hotfix/share-requests

📝 Commits (1)

ae129c6 fix: prevent exceptions with ShortcodeListAdapter initialization

📊 Changes

1 file changed (+4 additions, -0 deletions)

View changed files

📝 packages/hoppscotch-common/src/components/share/index.vue (+4 -0)

📄 Description

Description

This PR aims at adding a safeguard to prevent an exception that can arise while attempting to initialize the ShortCodeListAdapter where the adapter is already initialized. This can happen while logging in on cloud with Shared Requests as the active tab.

Closes HFE-454.

Checks

My pull request adheres to the code style of this project
All the tests have passed

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3917 **Author:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Created:** 3/20/2024 **Status:** ✅ Merged **Merged:** 3/20/2024 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `release/2024.3.0` ← **Head:** `hotfix/share-requests` --- ### 📝 Commits (1) - [`ae129c6`](https://github.com/hoppscotch/hoppscotch/commit/ae129c6c528016c211cdbe5446f176649263c8d6) fix: prevent exceptions with `ShortcodeListAdapter` initialization ### 📊 Changes **1 file changed** (+4 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/components/share/index.vue` (+4 -0) </details> ### 📄 Description ### Description This PR aims at adding a safeguard to prevent an exception that can arise while attempting to initialize the `ShortCodeListAdapter` where the adapter is already initialized. This can happen while logging in on cloud with `Shared Requests` as the active tab. Closes HFE-454. ### Checks - [x] My pull request adheres to the code style of this project - [x] All the tests have passed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>