[PR #3881] [MERGED] fix: secret env bug in firebase due to undefined value #4567

New issue

Closed

opened 2026-03-17 02:05:34 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:05:34 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3881
Author: @nivedin
Created: 3/7/2024
Status: ✅ Merged
Merged: 3/13/2024
Merged by: @AndrewBastin

Base: release/2024.3.0 ← Head: fix/secret-var-bug

📝 Commits (4)

40e8696 fix: secret env bug in firebase due to undefined value
63cbaab chore: add uniqid when updating version
5f9f9ad refactor: use more charecter ID for env
a3da14d refactor: ensure empty string IDs fall back to the unique ID variant

📊 Changes

8 files changed (+26 additions, -24 deletions)

View changed files

📝 packages/hoppscotch-common/src/components/environments/my/Details.vue (+5 -7)
📝 packages/hoppscotch-common/src/components/environments/teams/Details.vue (+4 -6)
📝 packages/hoppscotch-common/src/helpers/import-export/import/insomniaEnv.ts (+2 -2)
📝 packages/hoppscotch-common/src/helpers/import-export/import/postmanEnv.ts (+2 -2)
➕ packages/hoppscotch-common/src/helpers/utils/uniqueID.ts (+3 -0)
📝 packages/hoppscotch-common/src/newstore/environments.ts (+5 -4)
📝 packages/hoppscotch-data/src/environment/index.ts (+2 -2)
📝 packages/hoppscotch-data/src/environment/v/1.ts (+3 -1)

📄 Description

Closes HFE-440

Description

This PR fixes the issue in secret environment feature where when pushing the environment with undefined value failed, resulting in empty secret env's.
Also add id while upgrading env version.

Checks

My pull request adheres to the code style of this project
My code requires changes to the documentation
I have updated the documentation as required
All the tests have passed

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3881 **Author:** [@nivedin](https://github.com/nivedin) **Created:** 3/7/2024 **Status:** ✅ Merged **Merged:** 3/13/2024 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `release/2024.3.0` ← **Head:** `fix/secret-var-bug` --- ### 📝 Commits (4) - [`40e8696`](https://github.com/hoppscotch/hoppscotch/commit/40e8696a9a9bc06e6f9151009b8f1a37fa3352a6) fix: secret env bug in firebase due to undefined value - [`63cbaab`](https://github.com/hoppscotch/hoppscotch/commit/63cbaabf0783e5a83e85d1e5e4f5f029343c01de) chore: add uniqid when updating version - [`5f9f9ad`](https://github.com/hoppscotch/hoppscotch/commit/5f9f9addaf847665e2140b9625aabd2ea60f17d7) refactor: use more charecter ID for env - [`a3da14d`](https://github.com/hoppscotch/hoppscotch/commit/a3da14d39286536fbae8c5d06bd8167faba94cf4) refactor: ensure empty string IDs fall back to the unique ID variant ### 📊 Changes **8 files changed** (+26 additions, -24 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/components/environments/my/Details.vue` (+5 -7) 📝 `packages/hoppscotch-common/src/components/environments/teams/Details.vue` (+4 -6) 📝 `packages/hoppscotch-common/src/helpers/import-export/import/insomniaEnv.ts` (+2 -2) 📝 `packages/hoppscotch-common/src/helpers/import-export/import/postmanEnv.ts` (+2 -2) ➕ `packages/hoppscotch-common/src/helpers/utils/uniqueID.ts` (+3 -0) 📝 `packages/hoppscotch-common/src/newstore/environments.ts` (+5 -4) 📝 `packages/hoppscotch-data/src/environment/index.ts` (+2 -2) 📝 `packages/hoppscotch-data/src/environment/v/1.ts` (+3 -1) </details> ### 📄 Description Closes HFE-440 ### Description This PR fixes the issue in secret environment feature where when pushing the environment with `undefined` value failed, resulting in empty secret env's. Also add id while upgrading env version. ### Checks - [x] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [ ] I have updated the documentation as required - [x] All the tests have passed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>