[PR #3878] [MERGED] feat: common changes for site protection #4563

New issue

Closed

opened 2026-03-17 02:05:18 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:05:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3878
Author: @amk-dev
Created: 3/5/2024
Status: ✅ Merged
Merged: 3/7/2024
Merged by: @AndrewBastin

Base: release/2024.3.0 ← Head: feat/site-protection

📝 Commits (1)

fcf067e feat: common changes for site protection

📊 Changes

4 files changed (+16 additions, -4 deletions)

View changed files

📝 packages/hoppscotch-common/locales/en.json (+5 -0)
📝 packages/hoppscotch-common/src/modules/index.ts (+1 -1)
📝 packages/hoppscotch-common/src/modules/router.ts (+9 -3)
📝 packages/hoppscotch-common/src/pages/enter.vue (+1 -0)

📄 Description

Fixs HFE-410

Changes

make router beforeEach guard wait for the modules returning promises to resolve before going to the target route
allow guest only access for enter.vue, this is a requirement to prevent getting redirected to login-required page if site protection is enabled, because we use enter for verifying the magic link
add i18n entries for site protection related texts

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3878 **Author:** [@amk-dev](https://github.com/amk-dev) **Created:** 3/5/2024 **Status:** ✅ Merged **Merged:** 3/7/2024 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `release/2024.3.0` ← **Head:** `feat/site-protection` --- ### 📝 Commits (1) - [`fcf067e`](https://github.com/hoppscotch/hoppscotch/commit/fcf067ed62a097df0f255eb75cd5275f5bfecc55) feat: common changes for site protection ### 📊 Changes **4 files changed** (+16 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/locales/en.json` (+5 -0) 📝 `packages/hoppscotch-common/src/modules/index.ts` (+1 -1) 📝 `packages/hoppscotch-common/src/modules/router.ts` (+9 -3) 📝 `packages/hoppscotch-common/src/pages/enter.vue` (+1 -0) </details> ### 📄 Description Fixs HFE-410 **Changes** 1. make router beforeEach guard wait for the modules returning promises to resolve before going to the target route 2. allow guest only access for enter.vue, this is a requirement to prevent getting redirected to login-required page if site protection is enabled, because we use enter for verifying the magic link 3. add i18n entries for site protection related texts --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>