[PR #3851] [MERGED] refactor: possible links in email templates do not highlight #4556

New issue

Closed

opened 2026-03-17 02:05:02 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:05:02 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3851
Author: @AndrewBastin
Created: 2/21/2024
Status: ✅ Merged
Merged: 2/22/2024
Merged by: @AndrewBastin

Base: release/2023.12.6 ← Head: fix/email-link-highlighting

📝 Commits (3)

3c32b90 fix: make it so links in email templates do not highlight
4538bb2 fix: set the cursor to the default arrow
c764cf7 chore: change the subject in team invitation

📊 Changes

3 files changed (+72 additions, -60 deletions)

View changed files

📝 packages/hoppscotch-backend/src/mailer/mailer.service.ts (+1 -1)
📝 packages/hoppscotch-backend/src/mailer/templates/team-invitation.hbs (+8 -2)
📝 packages/hoppscotch-backend/src/mailer/templates/user-invitation.hbs (+63 -57)

📄 Description

NOTE: This PR is made in response to a moderate security advisory

Goal

If something representable as a site name or something is present in a Team Invitation (which is possible if the team name or the user name contains things which can look like phone numbers, sites or emails), those text should not be converted into links that the user can click through.

Implementation

We wrap around the variable bits in the template in an anchor tag to prevent the Email clients doing it on their end and style it so no UI weirdness happens.

Checks

My pull request adheres to the code style of this project
My code requires changes to the documentation
I have updated the documentation as required
All the tests have passed

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3851 **Author:** [@AndrewBastin](https://github.com/AndrewBastin) **Created:** 2/21/2024 **Status:** ✅ Merged **Merged:** 2/22/2024 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `release/2023.12.6` ← **Head:** `fix/email-link-highlighting` --- ### 📝 Commits (3) - [`3c32b90`](https://github.com/hoppscotch/hoppscotch/commit/3c32b902c3e37292e5e5425be49b3d2eb7c60831) fix: make it so links in email templates do not highlight - [`4538bb2`](https://github.com/hoppscotch/hoppscotch/commit/4538bb24d37dccaee36badb114ca5da09f00e51b) fix: set the cursor to the default arrow - [`c764cf7`](https://github.com/hoppscotch/hoppscotch/commit/c764cf79201d8d72dd01e038d6d0b9b60fcc9dee) chore: change the subject in team invitation ### 📊 Changes **3 files changed** (+72 additions, -60 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-backend/src/mailer/mailer.service.ts` (+1 -1) 📝 `packages/hoppscotch-backend/src/mailer/templates/team-invitation.hbs` (+8 -2) 📝 `packages/hoppscotch-backend/src/mailer/templates/user-invitation.hbs` (+63 -57) </details> ### 📄 Description NOTE: This PR is made in response to a moderate security advisory ### Goal If something representable as a site name or something is present in a Team Invitation (which is possible if the team name or the user name contains things which can look like phone numbers, sites or emails), those text should not be converted into links that the user can click through. ### Implementation We wrap around the variable bits in the template in an anchor tag to prevent the Email clients doing it on their end and style it so no UI weirdness happens. ### Checks - [x] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [ ] I have updated the documentation as required - [x] All the tests have passed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>