[PR #3817] [MERGED] fix: secret environment flow bugs #4539

New issue

Closed

opened 2026-03-17 02:03:56 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:03:56 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3817
Author: @nivedin
Created: 2/9/2024
Status: ✅ Merged
Merged: 2/10/2024
Merged by: @AndrewBastin

Base: release/2023.12.4 ← Head: fix/secret-env-bugs

📝 Commits (2)

aba9fe9 fix: empty env value inspector bug
a78eb2d chore: update i18n texts

📊 Changes

7 files changed (+49 additions, -15 deletions)

View changed files

📝 packages/hoppscotch-common/locales/en.json (+2 -2)
📝 packages/hoppscotch-common/src/components/environments/my/Details.vue (+1 -1)
📝 packages/hoppscotch-common/src/components/environments/teams/Details.vue (+1 -1)
📝 packages/hoppscotch-common/src/helpers/editor/extensions/HoppEnvironment.ts (+17 -7)
📝 packages/hoppscotch-common/src/newstore/environments.ts (+2 -2)
📝 packages/hoppscotch-common/src/services/inspection/inspectors/environment.inspector.ts (+11 -2)
📝 packages/hoppscotch-common/src/services/secret-environment.service.ts (+15 -0)

📄 Description

Closes HFE-425

Description

This PR fixes some bugs in the secret environment flow

Inspector shows warning that environment variable is empty even though variable within the environment has value
When clicking add to environment via inspector, inspector opens up global env and is not recognising the variable from the env

Checks

My pull request adheres to the code style of this project
My code requires changes to the documentation
I have updated the documentation as required
All the tests have passed

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3817 **Author:** [@nivedin](https://github.com/nivedin) **Created:** 2/9/2024 **Status:** ✅ Merged **Merged:** 2/10/2024 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `release/2023.12.4` ← **Head:** `fix/secret-env-bugs` --- ### 📝 Commits (2) - [`aba9fe9`](https://github.com/hoppscotch/hoppscotch/commit/aba9fe9ca7499ebaa65e26db7954aa1a6b346a54) fix: empty env value inspector bug - [`a78eb2d`](https://github.com/hoppscotch/hoppscotch/commit/a78eb2dee3cadd08847cd6ca39e551940d8af228) chore: update i18n texts ### 📊 Changes **7 files changed** (+49 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/locales/en.json` (+2 -2) 📝 `packages/hoppscotch-common/src/components/environments/my/Details.vue` (+1 -1) 📝 `packages/hoppscotch-common/src/components/environments/teams/Details.vue` (+1 -1) 📝 `packages/hoppscotch-common/src/helpers/editor/extensions/HoppEnvironment.ts` (+17 -7) 📝 `packages/hoppscotch-common/src/newstore/environments.ts` (+2 -2) 📝 `packages/hoppscotch-common/src/services/inspection/inspectors/environment.inspector.ts` (+11 -2) 📝 `packages/hoppscotch-common/src/services/secret-environment.service.ts` (+15 -0) </details> ### 📄 Description Closes HFE-425 ### Description This PR fixes some bugs in the secret environment flow - Inspector shows warning that environment variable is empty even though variable within the environment has value - When clicking add to environment via inspector, inspector opens up global env and is not recognising the variable from the env ### Checks - [x] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [ ] I have updated the documentation as required - [x] All the tests have passed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>