[PR #3812] [MERGED] fix(sh-admin): persist active selection in the sidebar #4533

New issue

Closed

opened 2026-03-17 02:03:40 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:03:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3812
Author: @jamesgeorge007
Created: 2/8/2024
Status: ✅ Merged
Merged: 2/8/2024
Merged by: @AndrewBastin

Base: release/2023.12.4 ← Head: hotfix/sh-admin-sidebar-active-selection

📝 Commits (1)

d72c060 fix: persist active selection in the sidebar for the Admin dashboard

📊 Changes

1 file changed (+10 additions, -8 deletions)

View changed files

📝 packages/hoppscotch-sh-admin/src/components/app/Sidebar.vue (+10 -8)

📄 Description

Description

This PR ensures the active selection in the sidebar for the Admin dashboard is persisted across page reloads. A new property, baseRouteName is introduced under primaryNavigations in the AppSidebar component that defines the base route names corresponding to each nav item and checks against the route name to decide whether to apply the classes for active selection or not.

Closes HFE-424.

Preview

https://github.com/hoppscotch/hoppscotch/assets/25279263/790ed666-d5a0-405d-8bb2-bd5a9a3cc10d

Checks

My pull request adheres to the code style of this project
All the tests have passed

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3812 **Author:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Created:** 2/8/2024 **Status:** ✅ Merged **Merged:** 2/8/2024 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `release/2023.12.4` ← **Head:** `hotfix/sh-admin-sidebar-active-selection` --- ### 📝 Commits (1) - [`d72c060`](https://github.com/hoppscotch/hoppscotch/commit/d72c06043418b92a97ef83dfb83d2a0327e92793) fix: persist active selection in the sidebar for the Admin dashboard ### 📊 Changes **1 file changed** (+10 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-sh-admin/src/components/app/Sidebar.vue` (+10 -8) </details> ### 📄 Description ### Description This PR ensures the active selection in the sidebar for the Admin dashboard is persisted across page reloads. A new property, `baseRouteName` is introduced under `primaryNavigations` in the `AppSidebar` component that defines the base route names corresponding to each nav item and checks against the route name to decide whether to apply the classes for active selection or not. Closes HFE-424. ### Preview https://github.com/hoppscotch/hoppscotch/assets/25279263/790ed666-d5a0-405d-8bb2-bd5a9a3cc10d ### Checks - [x] My pull request adheres to the code style of this project - [x] All the tests have passed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>