mirror of
https://github.com/hoppscotch/hoppscotch.git
synced 2026-04-26 01:06:00 +03:00
[GH-ISSUE #1396] toBeLevelxxx() test functions are broken #452
Labels
No labels
CodeDay
a11y
browser limited
bug
bug fix
cli
core
critical
design
desktop
discussion
docker
documentation
duplicate
enterprise
feature
feature
fosshack
future
good first issue
hacktoberfest
help wanted
i18n
invalid
major
minor
need information
need testing
not applicable to hoppscotch
not reproducible
pull-request
question
refactor
resolved
sandbox
self-host
spam
stale
testmu
wip
wont fix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hoppscotch#452
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @carlos-ds on GitHub (Dec 21, 2020).
Original GitHub issue: https://github.com/hoppscotch/hoppscotch/issues/1396
I was working on writing some more unit tests for the test functions in the application. And in the process of doing so, I discovered that the function for toBeLevel2xx() and similarly toBeLevel3xx(), toBeLevel4xx(), toBeLevel5xx() aren't working as expected.
Sticking to toBeLevel2xx(): given a 200 response status, it's indicating FAIL for the simplest of assertions:
I'll create a PR to fix this.
@liyasthomas commented on GitHub (Dec 21, 2020):
Thanks for noticing this issue and quick PR 🚀
@AndrewBastin commented on GitHub (Dec 21, 2020):
Also a wonderful reasoning for why tests are important 🙃