[PR #3737] [MERGED] feat(sh-admin): introducing additional SSO related server configurations to dashboard #4512

Closed
opened 2026-03-17 02:02:35 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3737
Author: @joeljstephen
Created: 1/9/2024
Status: Merged
Merged: 3/8/2024
Merged by: @AndrewBastin

Base: release/2024.3.0Head: feat/dashboard-additional-configs


📝 Commits (10+)

  • b352e6d feat: new i18n strings for the new configs
  • 7308029 refactor: updated client and config handlers
  • 97434bd refactor: updated components to reflect callback and scope in sso configs
  • fcb2587 refactor: simplified retrieval of infra config values in useConfigHandler
  • 77269cd feat: new tenant property added to microsoft configs
  • 06e72ef fix: type issues in auth provider component
  • 80b72b7 style: increased width of inputs in all configs
  • 7971733 refactor: brought toggleMask and maskState back to auth providers
  • 816d7da chore: remove redundant code in auth provider component
  • 97daccd style: updated input width for smtp configs

📊 Changes

5 files changed (+153 additions, -69 deletions)

View changed files

📝 packages/hoppscotch-sh-admin/locales/en.json (+3 -0)
📝 packages/hoppscotch-sh-admin/src/components.d.ts (+6 -0)
📝 packages/hoppscotch-sh-admin/src/components/settings/AuthProvider.vue (+71 -38)
📝 packages/hoppscotch-sh-admin/src/components/settings/SmtpConfiguration.vue (+2 -2)
📝 packages/hoppscotch-sh-admin/src/composables/useConfigHandler.ts (+71 -29)

📄 Description

Ticket

  • Closes HFE-394
  • Depends on #3718

Description

This PR enables the Admin Dashboard to show additional SSO related server configurations.

The additions to SSO Configurations include:

  • GOOGLE_CALLBACK_URL
  • GOOGLE_SCOPE
  • GITHUB_CALLBACK_URL
  • GITHUB_SCOPE
  • MICROSOFT_CALLBACK_URL
  • MICROSOFT_SCOPE
  • MICROSOFT_TENANT

Objectives

  • Admin Dashboard should include the additional SSO related server configurations in the Settings page under Auth Providers.

Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3737 **Author:** [@joeljstephen](https://github.com/joeljstephen) **Created:** 1/9/2024 **Status:** ✅ Merged **Merged:** 3/8/2024 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `release/2024.3.0` ← **Head:** `feat/dashboard-additional-configs` --- ### 📝 Commits (10+) - [`b352e6d`](https://github.com/hoppscotch/hoppscotch/commit/b352e6d38694ca23a991e2e090123d88af188656) feat: new i18n strings for the new configs - [`7308029`](https://github.com/hoppscotch/hoppscotch/commit/7308029da1e240a9cc31e314cef32e7f6fe8d4f7) refactor: updated client and config handlers - [`97434bd`](https://github.com/hoppscotch/hoppscotch/commit/97434bd41ea377ab455a38318627d11cd1134dc3) refactor: updated components to reflect callback and scope in sso configs - [`fcb2587`](https://github.com/hoppscotch/hoppscotch/commit/fcb25870dfb719949dec9167e4386533b4df7ed7) refactor: simplified retrieval of infra config values in useConfigHandler - [`77269cd`](https://github.com/hoppscotch/hoppscotch/commit/77269cdcec62295672604706b7ecd33e2dc8b866) feat: new tenant property added to microsoft configs - [`06e72ef`](https://github.com/hoppscotch/hoppscotch/commit/06e72efcd771d6f8d3e379e89522166fc0c9fd5b) fix: type issues in auth provider component - [`80b72b7`](https://github.com/hoppscotch/hoppscotch/commit/80b72b72460bd55a8ba1878122fe100a6c7cb9ee) style: increased width of inputs in all configs - [`7971733`](https://github.com/hoppscotch/hoppscotch/commit/797173363e31c341cfeb990f5599b42c3e9cf516) refactor: brought toggleMask and maskState back to auth providers - [`816d7da`](https://github.com/hoppscotch/hoppscotch/commit/816d7da35b266ba45305a601ab3900c53b28f646) chore: remove redundant code in auth provider component - [`97daccd`](https://github.com/hoppscotch/hoppscotch/commit/97daccd1824b208f2529d590a016b0d8c954658d) style: updated input width for smtp configs ### 📊 Changes **5 files changed** (+153 additions, -69 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-sh-admin/locales/en.json` (+3 -0) 📝 `packages/hoppscotch-sh-admin/src/components.d.ts` (+6 -0) 📝 `packages/hoppscotch-sh-admin/src/components/settings/AuthProvider.vue` (+71 -38) 📝 `packages/hoppscotch-sh-admin/src/components/settings/SmtpConfiguration.vue` (+2 -2) 📝 `packages/hoppscotch-sh-admin/src/composables/useConfigHandler.ts` (+71 -29) </details> ### 📄 Description ### Ticket - Closes HFE-394 - Depends on #3718 ### Description This PR enables the Admin Dashboard to show additional SSO related server configurations. #### The additions to SSO Configurations include: - `GOOGLE_CALLBACK_URL` - `GOOGLE_SCOPE` - `GITHUB_CALLBACK_URL` - `GITHUB_SCOPE` - `MICROSOFT_CALLBACK_URL` - `MICROSOFT_SCOPE` - `MICROSOFT_TENANT` ### Objectives - [x] Admin Dashboard should include the additional SSO related server configurations in the Settings page under Auth Providers. ### Checks <!-- Make sure your pull request passes the CI checks and do check the following fields as needed - --> - [x] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [ ] I have updated the documentation as required - [x] All the tests have passed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-17 02:02:35 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#4512
No description provided.