[PR #3730] [MERGED] fix: documentation is not being generated on GQL #4507

New issue

Closed

opened 2026-03-17 02:02:18 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:02:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3730
Author: @anwarulislam
Created: 1/7/2024
Status: ✅ Merged
Merged: 1/23/2024
Merged by: @AndrewBastin

Base: release/2023.12.3 ← Head: fix/gql-docs-render

📝 Commits (3)

cb70a36 fix: gql docs render issue
6e40109 chore: abstract to common helper function
2a8dc72 chore: use getNamedType instead of resolveRootType

📊 Changes

2 files changed (+4 additions, -16 deletions)

View changed files

📝 packages/hoppscotch-common/src/components/graphql/Sidebar.vue (+2 -8)
📝 packages/hoppscotch-common/src/components/graphql/TypeLink.vue (+2 -8)

📄 Description

Closes HFE-380

Description

Updated the resolveRootType function to correctly handle GraphQL types that do not have an ofType property. The function now uses a while loop to traverse the ofType chain until it reaches a type that does not contain any other types (i.e., its ofType property is null). This ensures that the function always returns the correct root type for any given GraphQL type.

Not Completed
Completed

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3730 **Author:** [@anwarulislam](https://github.com/anwarulislam) **Created:** 1/7/2024 **Status:** ✅ Merged **Merged:** 1/23/2024 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `release/2023.12.3` ← **Head:** `fix/gql-docs-render` --- ### 📝 Commits (3) - [`cb70a36`](https://github.com/hoppscotch/hoppscotch/commit/cb70a361e37a1b39b04df2fe4f9c20391b324f7d) fix: gql docs render issue - [`6e40109`](https://github.com/hoppscotch/hoppscotch/commit/6e40109722b9dde1a4dee9a2cfc5f30ef1607501) chore: abstract to common helper function - [`2a8dc72`](https://github.com/hoppscotch/hoppscotch/commit/2a8dc72beff7b2fcdf892cd3e32659787579a796) chore: use getNamedType instead of resolveRootType ### 📊 Changes **2 files changed** (+4 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/components/graphql/Sidebar.vue` (+2 -8) 📝 `packages/hoppscotch-common/src/components/graphql/TypeLink.vue` (+2 -8) </details> ### 📄 Description Closes HFE-380 ### Description Updated the `resolveRootType` function to correctly handle GraphQL types that do not have an `ofType` property. The function now uses a while loop to traverse the `ofType` chain until it reaches a type that does not contain any other types (i.e., its ofType property is null). This ensures that the function always returns the correct root type for any given GraphQL type. - [ ] Not Completed - [x] Completed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>