[PR #3718] [MERGED] HBE-345 feature: sso callback url and scope added in infra-config #4501

New issue

Closed

opened 2026-03-17 02:02:02 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:02:02 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3718
Author: @mirarifhasan
Created: 1/4/2024
Status: ✅ Merged
Merged: 3/7/2024
Merged by: @AndrewBastin

Base: release/2024.3.0 ← Head: feat/server-config-additional-properties

📝 Commits (10+)

9c00d62 feat: sso callback url and scope added in infra-config
b6b6acd fix: validate url function
0c13ca7 feat: update configService in strategy file
1be466e fix: code scanning issue
2ba79a0 fix: url regex update
9e9907b feat: feedback implemented
600e0ee fix: checks added for infraConfig table containing missing value or not
2d7fb8e fix: pnpm issue
01fd27f feat: infra config key check added instead of count check
b0b7df0 feat: removed unnecessary checks

📊 Changes

14 files changed (+394 additions, -144 deletions)

View changed files

📝 packages/hoppscotch-backend/src/admin/infra.resolver.ts (+3 -3)
📝 packages/hoppscotch-backend/src/auth/auth.module.ts (+9 -1)
📝 packages/hoppscotch-backend/src/auth/strategies/github.strategy.ts (+2 -2)
📝 packages/hoppscotch-backend/src/auth/strategies/google.strategy.ts (+2 -2)
📝 packages/hoppscotch-backend/src/auth/strategies/microsoft.strategy.ts (+3 -3)
📝 packages/hoppscotch-backend/src/errors.ts (+7 -0)
📝 packages/hoppscotch-backend/src/infra-config/helper.ts (+130 -1)
📝 packages/hoppscotch-backend/src/infra-config/infra-config.controller.ts (+3 -3)
📝 packages/hoppscotch-backend/src/infra-config/infra-config.model.ts (+3 -3)
📝 packages/hoppscotch-backend/src/infra-config/infra-config.service.spec.ts (+121 -7)
📝 packages/hoppscotch-backend/src/infra-config/infra-config.service.ts (+91 -99)
📝 packages/hoppscotch-backend/src/infra-config/input-args.ts (+3 -3)
📝 packages/hoppscotch-backend/src/types/InfraConfig.ts (+7 -17)
📝 packages/hoppscotch-backend/src/utils.ts (+10 -0)

📄 Description

Closes HBE-345

Description

This PR enables the Admin Dashboard to configure more attributes as a part of Server Config feature. Those attributes are:

GOOGLE_CALLBACK_URL
GOOGLE_SCOPE

MICROSOFT_CALLBACK_URL
MICROSOFT_SCOPE
MICROSOFT_TENANT

GITHUB_CALLBACK_URL
GITHUB_SCOPE

Checks

My pull request adheres to the code style of this project
My code requires changes to the documentation
I have updated the documentation as required
All the tests have passed

Additional Information

Nil

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3718 **Author:** [@mirarifhasan](https://github.com/mirarifhasan) **Created:** 1/4/2024 **Status:** ✅ Merged **Merged:** 3/7/2024 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `release/2024.3.0` ← **Head:** `feat/server-config-additional-properties` --- ### 📝 Commits (10+) - [`9c00d62`](https://github.com/hoppscotch/hoppscotch/commit/9c00d6238ec699ef1b5fb5b8fe465140759e9b2f) feat: sso callback url and scope added in infra-config - [`b6b6acd`](https://github.com/hoppscotch/hoppscotch/commit/b6b6acd2faa344a2a4e78644c36640305079683e) fix: validate url function - [`0c13ca7`](https://github.com/hoppscotch/hoppscotch/commit/0c13ca7dcac4e41a7a26fd5d4f13c492e2fb4ded) feat: update configService in strategy file - [`1be466e`](https://github.com/hoppscotch/hoppscotch/commit/1be466efcd4bcf85d99e6bec21bc807484af4847) fix: code scanning issue - [`2ba79a0`](https://github.com/hoppscotch/hoppscotch/commit/2ba79a043b9fed5c1891c20dc8e83e1386d7a345) fix: url regex update - [`9e9907b`](https://github.com/hoppscotch/hoppscotch/commit/9e9907b4bee47a113bd652ff9e9512f08f6fadaf) feat: feedback implemented - [`600e0ee`](https://github.com/hoppscotch/hoppscotch/commit/600e0eea766cc4128889feb8908d9445eaa5e12e) fix: checks added for infraConfig table containing missing value or not - [`2d7fb8e`](https://github.com/hoppscotch/hoppscotch/commit/2d7fb8e23a5ed7cce79752ccf3075de4a01abe49) fix: pnpm issue - [`01fd27f`](https://github.com/hoppscotch/hoppscotch/commit/01fd27f81adafc8f12e0624c72cee058c1722f2c) feat: infra config key check added instead of count check - [`b0b7df0`](https://github.com/hoppscotch/hoppscotch/commit/b0b7df0a3ef662656ef144296fa4305a07e73b42) feat: removed unnecessary checks ### 📊 Changes **14 files changed** (+394 additions, -144 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-backend/src/admin/infra.resolver.ts` (+3 -3) 📝 `packages/hoppscotch-backend/src/auth/auth.module.ts` (+9 -1) 📝 `packages/hoppscotch-backend/src/auth/strategies/github.strategy.ts` (+2 -2) 📝 `packages/hoppscotch-backend/src/auth/strategies/google.strategy.ts` (+2 -2) 📝 `packages/hoppscotch-backend/src/auth/strategies/microsoft.strategy.ts` (+3 -3) 📝 `packages/hoppscotch-backend/src/errors.ts` (+7 -0) 📝 `packages/hoppscotch-backend/src/infra-config/helper.ts` (+130 -1) 📝 `packages/hoppscotch-backend/src/infra-config/infra-config.controller.ts` (+3 -3) 📝 `packages/hoppscotch-backend/src/infra-config/infra-config.model.ts` (+3 -3) 📝 `packages/hoppscotch-backend/src/infra-config/infra-config.service.spec.ts` (+121 -7) 📝 `packages/hoppscotch-backend/src/infra-config/infra-config.service.ts` (+91 -99) 📝 `packages/hoppscotch-backend/src/infra-config/input-args.ts` (+3 -3) 📝 `packages/hoppscotch-backend/src/types/InfraConfig.ts` (+7 -17) 📝 `packages/hoppscotch-backend/src/utils.ts` (+10 -0) </details> ### 📄 Description    Closes HBE-345 ### Description  This PR enables the Admin Dashboard to configure more attributes as a part of Server Config feature. Those attributes are: ``` GOOGLE_CALLBACK_URL GOOGLE_SCOPE MICROSOFT_CALLBACK_URL MICROSOFT_SCOPE MICROSOFT_TENANT GITHUB_CALLBACK_URL GITHUB_SCOPE ```  ### Checks  - [x] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [ ] I have updated the documentation as required - [x] All the tests have passed ### Additional Information  Nil --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>