[PR #3704] [MERGED] fix: bugs in shared request #4497

New issue

Closed

opened 2026-03-17 02:01:46 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:01:46 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3704
Author: @nivedin
Created: 12/28/2023
Status: ✅ Merged
Merged: 1/23/2024
Merged by: @AndrewBastin

Base: release/2023.12.3 ← Head: fix/shared-request-bug

📝 Commits (10+)

ffff54b fix: update i18n text
6d7b0e1 fix: add loading and error state
a4aa808 chore: minor update for team header-auth properties
4a14de7 chore: minor code update
53e013e chore: minor padding update
52ef2d8 fix: remove redundant array creation
6ed4b73 chore: code refactor
80eb4c7 fix: shortcode subscription failing to initialize
0a94c16 fix: no selected option tab during the initial load
58d3ef9 refactor: minor code update

📊 Changes

11 files changed (+67 additions, -35 deletions)

View changed files

📝 packages/hoppscotch-common/src/components/embeds/index.vue (+8 -3)
📝 packages/hoppscotch-common/src/components/http/RequestOptions.vue (+2 -2)
📝 packages/hoppscotch-common/src/components/share/CreateModal.vue (+4 -4)
📝 packages/hoppscotch-common/src/components/share/CustomizeModal.vue (+3 -3)
📝 packages/hoppscotch-common/src/components/share/Modal.vue (+4 -4)
📝 packages/hoppscotch-common/src/components/share/index.vue (+18 -10)
📝 packages/hoppscotch-common/src/components/share/templates/Embeds.vue (+1 -1)
📝 packages/hoppscotch-common/src/helpers/shortcode/ShortcodeListAdapter.ts (+3 -0)
📝 packages/hoppscotch-common/src/helpers/teams/TeamCollectionAdapter.ts (+13 -5)
📝 packages/hoppscotch-common/src/newstore/collections.ts (+1 -1)
📝 packages/hoppscotch-common/src/pages/e/_id.vue (+10 -2)

📄 Description

Closes HFE-367

Description

This PR fixes the bugs found in shared request feature.

Added loading state in embeds
fixed i18n string when deleting a already deleted shared request
fix shortcode subscription failing to initialize in some race condition.

Checks

My pull request adheres to the code style of this project
My code requires changes to the documentation
I have updated the documentation as required
All the tests have passed

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3704 **Author:** [@nivedin](https://github.com/nivedin) **Created:** 12/28/2023 **Status:** ✅ Merged **Merged:** 1/23/2024 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `release/2023.12.3` ← **Head:** `fix/shared-request-bug` --- ### 📝 Commits (10+) - [`ffff54b`](https://github.com/hoppscotch/hoppscotch/commit/ffff54b5af734703b7e0d23fb72475273c3f5681) fix: update i18n text - [`6d7b0e1`](https://github.com/hoppscotch/hoppscotch/commit/6d7b0e11a3e352bd30fdf4592f6d2e789798391c) fix: add loading and error state - [`a4aa808`](https://github.com/hoppscotch/hoppscotch/commit/a4aa808103bbeaffa7d4ab0c7d6de0c954b357b6) chore: minor update for team header-auth properties - [`4a14de7`](https://github.com/hoppscotch/hoppscotch/commit/4a14de76c98e8139bc20bc176ce880bb695c1c14) chore: minor code update - [`53e013e`](https://github.com/hoppscotch/hoppscotch/commit/53e013e2a450c8788bcc15b0fd82ce11cb432542) chore: minor padding update - [`52ef2d8`](https://github.com/hoppscotch/hoppscotch/commit/52ef2d8d32bbe31de219bfc0b5dfeea3103b82d7) fix: remove redundant array creation - [`6ed4b73`](https://github.com/hoppscotch/hoppscotch/commit/6ed4b73a34c5f4a1cec215f23f7312adee9b759c) chore: code refactor - [`80eb4c7`](https://github.com/hoppscotch/hoppscotch/commit/80eb4c770169c526e113ec8dce6b2bf961d24588) fix: shortcode subscription failing to initialize - [`0a94c16`](https://github.com/hoppscotch/hoppscotch/commit/0a94c169bd970485838ac909425d9a6f20161316) fix: no selected option tab during the initial load - [`58d3ef9`](https://github.com/hoppscotch/hoppscotch/commit/58d3ef900fb48632f97183a60c632325893d7466) refactor: minor code update ### 📊 Changes **11 files changed** (+67 additions, -35 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/components/embeds/index.vue` (+8 -3) 📝 `packages/hoppscotch-common/src/components/http/RequestOptions.vue` (+2 -2) 📝 `packages/hoppscotch-common/src/components/share/CreateModal.vue` (+4 -4) 📝 `packages/hoppscotch-common/src/components/share/CustomizeModal.vue` (+3 -3) 📝 `packages/hoppscotch-common/src/components/share/Modal.vue` (+4 -4) 📝 `packages/hoppscotch-common/src/components/share/index.vue` (+18 -10) 📝 `packages/hoppscotch-common/src/components/share/templates/Embeds.vue` (+1 -1) 📝 `packages/hoppscotch-common/src/helpers/shortcode/ShortcodeListAdapter.ts` (+3 -0) 📝 `packages/hoppscotch-common/src/helpers/teams/TeamCollectionAdapter.ts` (+13 -5) 📝 `packages/hoppscotch-common/src/newstore/collections.ts` (+1 -1) 📝 `packages/hoppscotch-common/src/pages/e/_id.vue` (+10 -2) </details> ### 📄 Description Closes HFE-367 ### Description This PR fixes the bugs found in shared request feature. - Added loading state in embeds - fixed i18n string when deleting a already deleted shared request - fix shortcode subscription failing to initialize in some race condition. ### Checks - [x] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [ ] I have updated the documentation as required - [x] All the tests have passed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>