[PR #3694] [CLOSED] refactor: improvements to the teams module in admin dashboard #4493

New issue

Closed

opened 2026-03-17 02:01:29 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:01:29 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3694
Author: @joeljstephen
Created: 12/22/2023
Status: ❌ Closed

Base: release/2023.12.3 ← Head: refactor/dashboard-teams

📝 Commits (10+)

2c556a1 feat: new composable to handle useClientHandle related queries
8eb068a refactor: team id page now uses the useClientHandler composable to fetch team details
b23f316 refactor: better prop types for invite component
d49e671 refactor: allow two way binding for team data in details component
41c1a19 refactor: team info is called again in members component to retrieve updated member list
df1f760 refactor: improve reactivity when members are added or removed and when roles are changed
8337cc2 chore: remove unused emits from member component
02dc44e refactor: brought rename team name logic to details component and improved logic
333408c refactor: replaced text with i18n strings in invite component
8fdac58 refactor: minor code improvements across components

📊 Changes

11 files changed (+488 additions, -455 deletions)

View changed files

➕ packages/hoppscotch-sh-admin/assets/images/add_group.svg (+37 -0)
📝 packages/hoppscotch-sh-admin/locales/en.json (+18 -7)
📝 packages/hoppscotch-sh-admin/src/components.d.ts (+44 -42)
📝 packages/hoppscotch-sh-admin/src/components/teams/Add.vue (+10 -7)
📝 packages/hoppscotch-sh-admin/src/components/teams/Details.vue (+72 -28)
📝 packages/hoppscotch-sh-admin/src/components/teams/Invite.vue (+82 -71)
📝 packages/hoppscotch-sh-admin/src/components/teams/Members.vue (+83 -70)
📝 packages/hoppscotch-sh-admin/src/components/teams/PendingInvites.vue (+55 -82)
📝 packages/hoppscotch-sh-admin/src/composables/useClientHandler.ts (+15 -10)
📝 packages/hoppscotch-sh-admin/src/pages/teams/_id.vue (+34 -94)
📝 packages/hoppscotch-sh-admin/src/pages/teams/index.vue (+38 -44)

📄 Description

Ticket

Closes HFE-373

Description

This PR focuses on improving the teams module in Admin Dashboard. Each component related to the teams module is refactored and improved upon and minor bugs found are fixed.

Objectives

Refactor teams module in admin dashboard

Checks

My pull request adheres to the code style of this project
My code requires changes to the documentation
I have updated the documentation as required
All the tests have passed

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3694 **Author:** [@joeljstephen](https://github.com/joeljstephen) **Created:** 12/22/2023 **Status:** ❌ Closed **Base:** `release/2023.12.3` ← **Head:** `refactor/dashboard-teams` --- ### 📝 Commits (10+) - [`2c556a1`](https://github.com/hoppscotch/hoppscotch/commit/2c556a19e3e472880af0882ff87e3c8ee2811b27) feat: new composable to handle useClientHandle related queries - [`8eb068a`](https://github.com/hoppscotch/hoppscotch/commit/8eb068a58d5cc682fdde74c11224c091bff8ea18) refactor: team id page now uses the useClientHandler composable to fetch team details - [`b23f316`](https://github.com/hoppscotch/hoppscotch/commit/b23f3165ea17c75849fc71472159b7d67bb189a5) refactor: better prop types for invite component - [`d49e671`](https://github.com/hoppscotch/hoppscotch/commit/d49e6710378192161f75172951a11419bd12eb77) refactor: allow two way binding for team data in details component - [`41c1a19`](https://github.com/hoppscotch/hoppscotch/commit/41c1a19b5e7a6aa8f3371b7827ee77691cfb6218) refactor: team info is called again in members component to retrieve updated member list - [`df1f760`](https://github.com/hoppscotch/hoppscotch/commit/df1f7602968a46661374f737a1bdbfa2008b61e6) refactor: improve reactivity when members are added or removed and when roles are changed - [`8337cc2`](https://github.com/hoppscotch/hoppscotch/commit/8337cc255e47a33a56df4262a0e0dc657855c9ef) chore: remove unused emits from member component - [`02dc44e`](https://github.com/hoppscotch/hoppscotch/commit/02dc44ee635a9a1f4adce2e18373a28ecc96b23d) refactor: brought rename team name logic to details component and improved logic - [`333408c`](https://github.com/hoppscotch/hoppscotch/commit/333408c959bb7ad7aaa43e942c0d16d68799b254) refactor: replaced text with i18n strings in invite component - [`8fdac58`](https://github.com/hoppscotch/hoppscotch/commit/8fdac58d397352c80adbda9b33a822d65ad31cd1) refactor: minor code improvements across components ### 📊 Changes **11 files changed** (+488 additions, -455 deletions) <details> <summary>View changed files</summary> ➕ `packages/hoppscotch-sh-admin/assets/images/add_group.svg` (+37 -0) 📝 `packages/hoppscotch-sh-admin/locales/en.json` (+18 -7) 📝 `packages/hoppscotch-sh-admin/src/components.d.ts` (+44 -42) 📝 `packages/hoppscotch-sh-admin/src/components/teams/Add.vue` (+10 -7) 📝 `packages/hoppscotch-sh-admin/src/components/teams/Details.vue` (+72 -28) 📝 `packages/hoppscotch-sh-admin/src/components/teams/Invite.vue` (+82 -71) 📝 `packages/hoppscotch-sh-admin/src/components/teams/Members.vue` (+83 -70) 📝 `packages/hoppscotch-sh-admin/src/components/teams/PendingInvites.vue` (+55 -82) 📝 `packages/hoppscotch-sh-admin/src/composables/useClientHandler.ts` (+15 -10) 📝 `packages/hoppscotch-sh-admin/src/pages/teams/_id.vue` (+34 -94) 📝 `packages/hoppscotch-sh-admin/src/pages/teams/index.vue` (+38 -44) </details> ### 📄 Description ### Ticket Closes HFE-373 ### Description This PR focuses on improving the teams module in Admin Dashboard. Each component related to the teams module is refactored and improved upon and minor bugs found are fixed. ### Objectives - [x] Refactor teams module in admin dashboard ### Checks  - [x] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [ ] I have updated the documentation as required - [x] All the tests have passed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>