[PR #3690] [CLOSED] fix: minor updation for shared request and auth-headers features #4492

New issue

Closed

opened 2026-03-17 02:01:29 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:01:29 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3690
Author: @nivedin
Created: 12/22/2023
Status: ❌ Closed

Base: 2023.12.1 ← Head: fix/shared-request-bugs

📝 Commits (6)

1ac518e fix: update i18n text
2ed43f0 fix: add loading and error state
cf4ecd3 chore: minor update for team header-auth properties
4f74cd8 chore: minor code update
9bd7961 chore: minor padding update
b5e7577 fix: saving teamRequest not inheriting properties

📊 Changes

8 files changed (+94 additions, -6 deletions)

View changed files

📝 packages/hoppscotch-common/src/components/collections/SaveRequest.vue (+41 -2)
📝 packages/hoppscotch-common/src/components/collections/index.vue (+2 -0)
📝 packages/hoppscotch-common/src/components/share/index.vue (+2 -2)
📝 packages/hoppscotch-common/src/helpers/backend/gql/mutations/UpdateRequest.graphql (+1 -0)
📝 packages/hoppscotch-common/src/helpers/shortcode/ShortcodeListAdapter.ts (+3 -0)
📝 packages/hoppscotch-common/src/helpers/teams/TeamCollectionAdapter.ts (+9 -1)
📝 packages/hoppscotch-common/src/newstore/collections.ts (+1 -1)
📝 packages/hoppscotch-common/src/pages/e/_id.vue (+35 -0)

📄 Description

Closes HFE-367

Description

This PR fixes some of the minor bugs in the shared request and auth-headers in collection features.

Added loading state in embeds
fixed i18n string when deleting a already deleted shared request
minor code update on team auth-header cascading folder path
Saving team request failed to inherit property.

Checks

My pull request adheres to the code style of this project
My code requires changes to the documentation
I have updated the documentation as required
All the tests have passed

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3690 **Author:** [@nivedin](https://github.com/nivedin) **Created:** 12/22/2023 **Status:** ❌ Closed **Base:** `2023.12.1` ← **Head:** `fix/shared-request-bugs` --- ### 📝 Commits (6) - [`1ac518e`](https://github.com/hoppscotch/hoppscotch/commit/1ac518ef87f50bca7507628d28897de2a9bbb81d) fix: update i18n text - [`2ed43f0`](https://github.com/hoppscotch/hoppscotch/commit/2ed43f03e17b6ca8bee5b2e8a71218d7d8da98eb) fix: add loading and error state - [`cf4ecd3`](https://github.com/hoppscotch/hoppscotch/commit/cf4ecd326e0eafb4ac9110e7d52dbf5060e67520) chore: minor update for team header-auth properties - [`4f74cd8`](https://github.com/hoppscotch/hoppscotch/commit/4f74cd8f89f7785886ef391680521987d867572a) chore: minor code update - [`9bd7961`](https://github.com/hoppscotch/hoppscotch/commit/9bd7961c156d79f5786ba6526b11a3ab4a8b07e6) chore: minor padding update - [`b5e7577`](https://github.com/hoppscotch/hoppscotch/commit/b5e757702408b9259bff72004efb7f22d890a687) fix: saving teamRequest not inheriting properties ### 📊 Changes **8 files changed** (+94 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/components/collections/SaveRequest.vue` (+41 -2) 📝 `packages/hoppscotch-common/src/components/collections/index.vue` (+2 -0) 📝 `packages/hoppscotch-common/src/components/share/index.vue` (+2 -2) 📝 `packages/hoppscotch-common/src/helpers/backend/gql/mutations/UpdateRequest.graphql` (+1 -0) 📝 `packages/hoppscotch-common/src/helpers/shortcode/ShortcodeListAdapter.ts` (+3 -0) 📝 `packages/hoppscotch-common/src/helpers/teams/TeamCollectionAdapter.ts` (+9 -1) 📝 `packages/hoppscotch-common/src/newstore/collections.ts` (+1 -1) 📝 `packages/hoppscotch-common/src/pages/e/_id.vue` (+35 -0) </details> ### 📄 Description Closes HFE-367 ### Description This PR fixes some of the minor bugs in the shared request and auth-headers in collection features. - Added loading state in embeds - fixed i18n string when deleting a already deleted shared request - minor code update on team auth-header cascading folder path - Saving team request failed to inherit property. ### Checks - [x] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [ ] I have updated the documentation as required - [x] All the tests have passed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>