[PR #3686] [CLOSED] refactor: added input validation to server configurations in admin dashboard #4490

New issue

Closed

opened 2026-03-17 02:01:13 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:01:13 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3686
Author: @joeljstephen
Created: 12/21/2023
Status: ❌ Closed

Base: release/2023.12.3 ← Head: feat/dashboard-config-validation

📝 Commits (9)

b5be78d refactor: replaced text with i18n string
b147d83 refactor: client handler is now used to fetch data and return it instead of a list
ecd63fb fix: wrong i18n string in server restart component
41437b4 fix: corrected cherry pick conflicts
cf39b6f refactor: combined logic of client handler into one file and updated config empty logic
7a817c7 refactor: removed input validation from server restart component
a7fcadf refactor: included input validation check in settings component
87c1f42 refactor: code improvements
9238df6 chore: add suggestions from review

📊 Changes

5 files changed (+85 additions, -43 deletions)

View changed files

📝 packages/hoppscotch-sh-admin/locales/en.json (+1 -0)
📝 packages/hoppscotch-sh-admin/src/components/settings/ServerRestart.vue (+5 -4)
📝 packages/hoppscotch-sh-admin/src/composables/useClientHandler.ts (+15 -10)
📝 packages/hoppscotch-sh-admin/src/composables/useConfigHandler.ts (+38 -19)
📝 packages/hoppscotch-sh-admin/src/pages/settings.vue (+26 -10)

📄 Description

Ticket

Closes HFE-363

Description

This PR introduces input validations to all server configuration input fields in the admin dashboard

Checks

My pull request adheres to the code style of this project
My code requires changes to the documentation
I have updated the documentation as required
All the tests have passed

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3686 **Author:** [@joeljstephen](https://github.com/joeljstephen) **Created:** 12/21/2023 **Status:** ❌ Closed **Base:** `release/2023.12.3` ← **Head:** `feat/dashboard-config-validation` --- ### 📝 Commits (9) - [`b5be78d`](https://github.com/hoppscotch/hoppscotch/commit/b5be78d9670d4c400a3ea7f575b004c18c24dd5b) refactor: replaced text with i18n string - [`b147d83`](https://github.com/hoppscotch/hoppscotch/commit/b147d83c85673cf753a13fd1463975fd73e174a7) refactor: client handler is now used to fetch data and return it instead of a list - [`ecd63fb`](https://github.com/hoppscotch/hoppscotch/commit/ecd63fbdc4749a6aa7170031df88ef473008122d) fix: wrong i18n string in server restart component - [`41437b4`](https://github.com/hoppscotch/hoppscotch/commit/41437b4f7a767d23fd856d9428eb729f1644fe04) fix: corrected cherry pick conflicts - [`cf39b6f`](https://github.com/hoppscotch/hoppscotch/commit/cf39b6f89c95c84ca39306af8acb1e7a0a0001ce) refactor: combined logic of client handler into one file and updated config empty logic - [`7a817c7`](https://github.com/hoppscotch/hoppscotch/commit/7a817c7c55c7ddc197efcf6111ed51d1bd8eb8b1) refactor: removed input validation from server restart component - [`a7fcadf`](https://github.com/hoppscotch/hoppscotch/commit/a7fcadf22a6b026c50c4f4dbd4a6f54a220f406d) refactor: included input validation check in settings component - [`87c1f42`](https://github.com/hoppscotch/hoppscotch/commit/87c1f424076cfa2929c9462f23a78ac7b9ac4fad) refactor: code improvements - [`9238df6`](https://github.com/hoppscotch/hoppscotch/commit/9238df622a4f5cfb8f1e180997b1d41d1820090d) chore: add suggestions from review ### 📊 Changes **5 files changed** (+85 additions, -43 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-sh-admin/locales/en.json` (+1 -0) 📝 `packages/hoppscotch-sh-admin/src/components/settings/ServerRestart.vue` (+5 -4) 📝 `packages/hoppscotch-sh-admin/src/composables/useClientHandler.ts` (+15 -10) 📝 `packages/hoppscotch-sh-admin/src/composables/useConfigHandler.ts` (+38 -19) 📝 `packages/hoppscotch-sh-admin/src/pages/settings.vue` (+26 -10) </details> ### 📄 Description ### Ticket Closes HFE-363 ### Description This PR introduces input validations to all server configuration input fields in the admin dashboard ### Checks  - [x] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [ ] I have updated the documentation as required - [x] All the tests have passed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>