[PR #3673] [MERGED] fix: fallback section for embeds if invalid link #4487

Closed
opened 2026-03-17 02:01:13 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3673
Author: @nivedin
Created: 12/19/2023
Status: Merged
Merged: 12/19/2023
Merged by: @AndrewBastin

Base: release/2023.12.0Head: fix/fallback-embeds-invalid-url


📝 Commits (2)

  • a2b5b9e fix: add fallback section for embeds
  • 9f0c20e chore: update i18n text

📊 Changes

2 files changed (+18 additions, -2 deletions)

View changed files

📝 packages/hoppscotch-common/locales/en.json (+1 -0)
📝 packages/hoppscotch-common/src/pages/e/_id.vue (+17 -2)

📄 Description

Description

This PR adds a fallback section for embeds if the link is invalid.

Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3673 **Author:** [@nivedin](https://github.com/nivedin) **Created:** 12/19/2023 **Status:** ✅ Merged **Merged:** 12/19/2023 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `release/2023.12.0` ← **Head:** `fix/fallback-embeds-invalid-url` --- ### 📝 Commits (2) - [`a2b5b9e`](https://github.com/hoppscotch/hoppscotch/commit/a2b5b9e256a048e058526c621791caa9830dba29) fix: add fallback section for embeds - [`9f0c20e`](https://github.com/hoppscotch/hoppscotch/commit/9f0c20e0d08c854dff7ae063b167fee7e7ee0a6c) chore: update i18n text ### 📊 Changes **2 files changed** (+18 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/locales/en.json` (+1 -0) 📝 `packages/hoppscotch-common/src/pages/e/_id.vue` (+17 -2) </details> ### 📄 Description ### Description This PR adds a fallback section for embeds if the link is invalid. ### Checks - [x] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [ ] I have updated the documentation as required - [x] All the tests have passed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-17 02:01:13 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#4487
No description provided.