[PR #3671] [MERGED] fix(persistence-service): update schemas found to differ in runtime #4486

New issue

Closed

opened 2026-03-17 02:01:13 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:01:13 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3671
Author: @jamesgeorge007
Created: 12/19/2023
Status: ✅ Merged
Merged: 12/19/2023
Merged by: @AndrewBastin

Base: release/2023.12.0 ← Head: hotfix/persistence-service-schemas

📝 Commits (4)

5824519 fix: update persistence service schemas found to differ in runtime
cf4b925 refactor: make settings fallback to the default settings if not present
8f9fc5e refactor: mark oauth2Token field optional under URL_EXCLUDES for settings
f392b96 refactor: rely on fallback instead of explicit casting

📊 Changes

2 files changed (+11 additions, -10 deletions)

View changed files

📝 packages/hoppscotch-common/src/services/persistence/index.ts (+5 -1)
📝 packages/hoppscotch-common/src/services/persistence/validation-schemas/index.ts (+6 -9)

📄 Description

Description

This PR aims at updating a few schemas under the persistence service that were found to differ from the incoming data at runtime.

Removes the empty object fallback for settings and makes it fallback to the default set of values if the key is not present in localStorage. The corresponding schema has also been updated.
Marks the clientID field as optional for the MQTT request schema and the oauth2Token field under URL_EXCLUDES for settings.

Checks

My pull request adheres to the code style of this project
All the tests have passed

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3671 **Author:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Created:** 12/19/2023 **Status:** ✅ Merged **Merged:** 12/19/2023 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `release/2023.12.0` ← **Head:** `hotfix/persistence-service-schemas` --- ### 📝 Commits (4) - [`5824519`](https://github.com/hoppscotch/hoppscotch/commit/582451931f6bb50bec765c1836126293b579ea86) fix: update persistence service schemas found to differ in runtime - [`cf4b925`](https://github.com/hoppscotch/hoppscotch/commit/cf4b92545e96d84fc410cc90e9f17e67f9c79f24) refactor: make settings fallback to the default settings if not present - [`8f9fc5e`](https://github.com/hoppscotch/hoppscotch/commit/8f9fc5e11d31a54fde3744063357f2ded95318b9) refactor: mark oauth2Token field optional under URL_EXCLUDES for settings - [`f392b96`](https://github.com/hoppscotch/hoppscotch/commit/f392b965de2f77c7dcadc96b8ab822f837e429d5) refactor: rely on fallback instead of explicit casting ### 📊 Changes **2 files changed** (+11 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/services/persistence/index.ts` (+5 -1) 📝 `packages/hoppscotch-common/src/services/persistence/validation-schemas/index.ts` (+6 -9) </details> ### 📄 Description ### Description This PR aims at updating a few schemas under the persistence service that were found to differ from the incoming data at runtime. - Removes the empty object fallback for settings and makes it fallback to the default set of values if the key is not present in `localStorage`. The corresponding schema has also been updated. - Marks the `clientID` field as optional for the MQTT request schema and the `oauth2Token` field under `URL_EXCLUDES` for `settings`. ### Checks - [x] My pull request adheres to the code style of this project - [x] All the tests have passed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>