[PR #3669] [MERGED] fix: actions not working when sidebar is hidden #4485

New issue

Closed

opened 2026-03-17 02:00:57 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:00:57 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3669
Author: @amk-dev
Created: 12/19/2023
Status: ✅ Merged
Merged: 12/19/2023
Merged by: @AndrewBastin

Base: release/2023.12.0 ← Head: fix/actions-not-working-without-sidebar

📝 Commits (1)

f862b4a fix: fix actions not triggered when sidebar is not open

📊 Changes

1 file changed (+5 additions, -5 deletions)

View changed files

📝 packages/hoppscotch-common/src/components/app/PaneLayout.vue (+5 -5)

📄 Description

Fixes HFE-357

Before

If the sidebar is hidden, actions from components inside the sidebar are not working.

this is caused by the Sidebar Pane unmounting, resulting in the components which houses these environment models unmounting, which results in the actions defined by the defineActionHandlers unbinding, which when triggered does nothing.
this is also affecting entires in the spotlight,

New Collection
Create New Environment
Delete Current Environment
Edit Environment
Edit Global Environment
etc.

After

First idea was to just use v-show instead of v-if for the pane. which will just hide the pane instead of unmounting it. this will fix our problem. but the library we use 'splitpanes' is not working properly with 'v-show'. But we simulate the behaviour by setting the pane size to 0 and hiding the splitter. This fixes the issue.

Note: this is a hotfix. The ideal way is to make a place where all our global models can be managed from. we need to make their state available globally as a service or something similar. this will be worked on later.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3669 **Author:** [@amk-dev](https://github.com/amk-dev) **Created:** 12/19/2023 **Status:** ✅ Merged **Merged:** 12/19/2023 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `release/2023.12.0` ← **Head:** `fix/actions-not-working-without-sidebar` --- ### 📝 Commits (1) - [`f862b4a`](https://github.com/hoppscotch/hoppscotch/commit/f862b4aaae9e4fa60cf3d7eca02c3b94108ebdeb) fix: fix actions not triggered when sidebar is not open ### 📊 Changes **1 file changed** (+5 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/components/app/PaneLayout.vue` (+5 -5) </details> ### 📄 Description Fixes HFE-357 **Before** If the sidebar is hidden, actions from components inside the sidebar are not working. this is caused by the Sidebar Pane unmounting, resulting in the components which houses these environment models unmounting, which results in the actions defined by the defineActionHandlers unbinding, which when triggered does nothing. this is also affecting entires in the spotlight, 1. New Collection 2. Create New Environment 3. Delete Current Environment 4. Edit Environment 5. Edit Global Environment etc. **After** First idea was to just use v-show instead of v-if for the pane. which will just hide the pane instead of unmounting it. this will fix our problem. but the library we use 'splitpanes' is not working properly with 'v-show'. But we simulate the behaviour by setting the pane size to 0 and hiding the splitter. This fixes the issue. Note: this is a hotfix. The ideal way is to make a place where all our global models can be managed from. we need to make their state available globally as a service or something similar. this will be worked on later. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>