[PR #3665] [MERGED] chore(common): Gist export flow updates #4483

Closed
opened 2026-03-17 02:00:57 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3665
Author: @jamesgeorge007
Created: 12/19/2023
Status: Merged
Merged: 12/19/2023
Merged by: @AndrewBastin

Base: release/2023.12.0Head: gist-export-flow-updates


📝 Commits (5)

  • 3540395 chore: Gist export flow updates
  • 6c5e1a6 refactor: eliminate redundancy
  • 2794062 refactor: organize imports
  • c2a2b46 refactor: rely on platform implementation for opening external links
  • d80b263 fix: pick the corresponding REST collections to export from personal/team workspace

📊 Changes

8 files changed (+102 additions, -93 deletions)

View changed files

📝 packages/hoppscotch-common/locales/en.json (+4 -2)
📝 packages/hoppscotch-common/src/components/collections/ImportExport.vue (+28 -8)
📝 packages/hoppscotch-common/src/components/collections/graphql/ImportExport.vue (+27 -16)
📝 packages/hoppscotch-common/src/components/environments/ImportExport.vue (+24 -9)
packages/hoppscotch-common/src/helpers/import-export/export/environmentsGistExport.ts (+0 -18)
packages/hoppscotch-common/src/helpers/import-export/export/gist.ts (+19 -0)
packages/hoppscotch-common/src/helpers/import-export/export/gistExport.ts (+0 -22)
packages/hoppscotch-common/src/helpers/import-export/export/gqlCollectionsGistExporter.ts (+0 -18)

📄 Description

Description

This PR brings a few updates to the export as secret Gist flow (only available on cloud), as mentioned below.

  • Adds loading spinner to the GQL and environment Gist export flows.

    https://github.com/hoppscotch/hoppscotch/assets/25279263/3938d67a-a671-4c5b-bdd7-c1715d141766

  • Enables opening the REST collections exported as a secret Gist in a new tab.

  • Updates the tooltip text for the Create secret Gist option. Ensures the appropriate text is displayed based on the user's logged-in status and the current provider if logged in.

    • Shows Export as secret Gist if logged in with GitHub or another provider with an Email that matches the primary Email associated with the GitHub account.

      image

    • Shows Login with GitHub to create secret gist if not authenticated or logged in to another provider with a different Email.

      image

  • Error toast is displayed during empty export attempts.

  • Compile common Gist export logic in helpers/import-export/export/gist.ts.

Closes HFE-360.

Checks

  • My pull request adheres to the code style of this project
  • All the tests have passed

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3665 **Author:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Created:** 12/19/2023 **Status:** ✅ Merged **Merged:** 12/19/2023 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `release/2023.12.0` ← **Head:** `gist-export-flow-updates` --- ### 📝 Commits (5) - [`3540395`](https://github.com/hoppscotch/hoppscotch/commit/354039588f5040f0b1adebdf029df57b75d4515c) chore: Gist export flow updates - [`6c5e1a6`](https://github.com/hoppscotch/hoppscotch/commit/6c5e1a6bc4df466db0cdb8cceb065267c0ce9406) refactor: eliminate redundancy - [`2794062`](https://github.com/hoppscotch/hoppscotch/commit/27940627c80f215614bae26cbf4efb3f9c0a55e0) refactor: organize imports - [`c2a2b46`](https://github.com/hoppscotch/hoppscotch/commit/c2a2b4643a64bc3121a9fa8a9f34f5d35fb5e48c) refactor: rely on platform implementation for opening external links - [`d80b263`](https://github.com/hoppscotch/hoppscotch/commit/d80b2630e225284c60b70953c1e1830fd98b8528) fix: pick the corresponding REST collections to export from personal/team workspace ### 📊 Changes **8 files changed** (+102 additions, -93 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/locales/en.json` (+4 -2) 📝 `packages/hoppscotch-common/src/components/collections/ImportExport.vue` (+28 -8) 📝 `packages/hoppscotch-common/src/components/collections/graphql/ImportExport.vue` (+27 -16) 📝 `packages/hoppscotch-common/src/components/environments/ImportExport.vue` (+24 -9) ➖ `packages/hoppscotch-common/src/helpers/import-export/export/environmentsGistExport.ts` (+0 -18) ➕ `packages/hoppscotch-common/src/helpers/import-export/export/gist.ts` (+19 -0) ➖ `packages/hoppscotch-common/src/helpers/import-export/export/gistExport.ts` (+0 -22) ➖ `packages/hoppscotch-common/src/helpers/import-export/export/gqlCollectionsGistExporter.ts` (+0 -18) </details> ### 📄 Description ### Description This PR brings a few updates to the export as secret Gist flow (only available on cloud), as mentioned below. - Adds loading spinner to the GQL and environment Gist export flows. https://github.com/hoppscotch/hoppscotch/assets/25279263/3938d67a-a671-4c5b-bdd7-c1715d141766 - Enables opening the REST collections exported as a secret Gist in a new tab. - Updates the tooltip text for the `Create secret Gist` option. Ensures the appropriate text is displayed based on the user's logged-in status and the current provider if logged in. - Shows `Export as secret Gist` if logged in with GitHub or another provider with an Email that matches the primary Email associated with the GitHub account. ![image](https://github.com/hoppscotch/hoppscotch/assets/25279263/3837186f-e990-4ab1-9222-67d7b7063f55) - Shows `Login with GitHub to create secret gist` if not authenticated or logged in to another provider with a different Email. ![image](https://github.com/hoppscotch/hoppscotch/assets/25279263/7621840e-c670-4cc4-95e7-30972626b8e3) - Error toast is displayed during empty export attempts. - Compile common Gist export logic in `helpers/import-export/export/gist.ts`. Closes HFE-360. ### Checks - [x] My pull request adheres to the code style of this project - [x] All the tests have passed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-17 02:00:57 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#4483
No description provided.