mirror of
https://github.com/hoppscotch/hoppscotch.git
synced 2026-04-25 16:55:59 +03:00
[PR #3665] [MERGED] chore(common): Gist export flow updates #4483
Labels
No labels
CodeDay
a11y
browser limited
bug
bug fix
cli
core
critical
design
desktop
discussion
docker
documentation
duplicate
enterprise
feature
feature
fosshack
future
good first issue
hacktoberfest
help wanted
i18n
invalid
major
minor
need information
need testing
not applicable to hoppscotch
not reproducible
pull-request
question
refactor
resolved
sandbox
self-host
spam
stale
testmu
wip
wont fix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hoppscotch#4483
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/hoppscotch/hoppscotch/pull/3665
Author: @jamesgeorge007
Created: 12/19/2023
Status: ✅ Merged
Merged: 12/19/2023
Merged by: @AndrewBastin
Base:
release/2023.12.0← Head:gist-export-flow-updates📝 Commits (5)
3540395chore: Gist export flow updates6c5e1a6refactor: eliminate redundancy2794062refactor: organize importsc2a2b46refactor: rely on platform implementation for opening external linksd80b263fix: pick the corresponding REST collections to export from personal/team workspace📊 Changes
8 files changed (+102 additions, -93 deletions)
View changed files
📝
packages/hoppscotch-common/locales/en.json(+4 -2)📝
packages/hoppscotch-common/src/components/collections/ImportExport.vue(+28 -8)📝
packages/hoppscotch-common/src/components/collections/graphql/ImportExport.vue(+27 -16)📝
packages/hoppscotch-common/src/components/environments/ImportExport.vue(+24 -9)➖
packages/hoppscotch-common/src/helpers/import-export/export/environmentsGistExport.ts(+0 -18)➕
packages/hoppscotch-common/src/helpers/import-export/export/gist.ts(+19 -0)➖
packages/hoppscotch-common/src/helpers/import-export/export/gistExport.ts(+0 -22)➖
packages/hoppscotch-common/src/helpers/import-export/export/gqlCollectionsGistExporter.ts(+0 -18)📄 Description
Description
This PR brings a few updates to the export as secret Gist flow (only available on cloud), as mentioned below.
Adds loading spinner to the GQL and environment Gist export flows.
https://github.com/hoppscotch/hoppscotch/assets/25279263/3938d67a-a671-4c5b-bdd7-c1715d141766
Enables opening the REST collections exported as a secret Gist in a new tab.
Updates the tooltip text for the
Create secret Gistoption. Ensures the appropriate text is displayed based on the user's logged-in status and the current provider if logged in.Shows
Export as secret Gistif logged in with GitHub or another provider with an Email that matches the primary Email associated with the GitHub account.Shows
Login with GitHub to create secret gistif not authenticated or logged in to another provider with a different Email.Error toast is displayed during empty export attempts.
Compile common Gist export logic in
helpers/import-export/export/gist.ts.Closes HFE-360.
Checks
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.