[PR #3667] [MERGED] hotfix: added validation on infra config update #4481

New issue

Closed

opened 2026-03-17 02:00:57 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:00:57 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3667
Author: @mirarifhasan
Created: 12/19/2023
Status: ✅ Merged
Merged: 12/19/2023
Merged by: @mirarifhasan

Base: release/2023.12.0 ← Head: hotfix/server-config

📝 Commits (3)

e0f468a feat: added validation on infra config update
629730a chore: removed async keyword
cb4b8a5 fix: feedback

📊 Changes

2 files changed (+71 additions, -3 deletions)

View changed files

📝 packages/hoppscotch-backend/src/errors.ts (+7 -0)
📝 packages/hoppscotch-backend/src/infra-config/infra-config.service.ts (+64 -3)

📄 Description

Description

In this PR added some validation when updating any variable in InfraConfig.

Some validations are:

SSO secrets can not be updated with the null or "" value.
Any SSO can not be enabled if its secret/client_id is not configured beforehand.

Checks

My pull request adheres to the code style of this project
My code requires changes to the documentation
I have updated the documentation as required
All the tests have passed

Additional Information

Nil

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3667 **Author:** [@mirarifhasan](https://github.com/mirarifhasan) **Created:** 12/19/2023 **Status:** ✅ Merged **Merged:** 12/19/2023 **Merged by:** [@mirarifhasan](https://github.com/mirarifhasan) **Base:** `release/2023.12.0` ← **Head:** `hotfix/server-config` --- ### 📝 Commits (3) - [`e0f468a`](https://github.com/hoppscotch/hoppscotch/commit/e0f468aa1c4ce6dfd3d012f24b1918b9db1d2397) feat: added validation on infra config update - [`629730a`](https://github.com/hoppscotch/hoppscotch/commit/629730a309b4f7721c3261bf52da707d45046048) chore: removed async keyword - [`cb4b8a5`](https://github.com/hoppscotch/hoppscotch/commit/cb4b8a587692d90955c53fd6f1b7887c67ca375d) fix: feedback ### 📊 Changes **2 files changed** (+71 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-backend/src/errors.ts` (+7 -0) 📝 `packages/hoppscotch-backend/src/infra-config/infra-config.service.ts` (+64 -3) </details> ### 📄 Description    ### Description  In this PR added some validation when updating any variable in InfraConfig. Some validations are: 1. SSO secrets can not be updated with the `null` or `""` value. 2. Any SSO can not be enabled if its secret/client_id is not configured beforehand.  ### Checks  - [x] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [ ] I have updated the documentation as required - [x] All the tests have passed ### Additional Information  Nil --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>