[PR #3659] [MERGED] fix: embeds system theme #4476

New issue

Closed

opened 2026-03-17 02:00:41 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:00:41 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3659
Author: @nivedin
Created: 12/15/2023
Status: ✅ Merged
Merged: 12/16/2023
Merged by: @AndrewBastin

Base: release/2023.12.0 ← Head: fix/embeds-theme

📝 Commits (3)

6e62ad5 fix: embeds system theme
b25997b refactor: minor change
4dabc7c chore: add suggestions from review

📊 Changes

2 files changed (+19 additions, -19 deletions)

View changed files

📝 packages/hoppscotch-common/src/components/share/templates/Embeds.vue (+18 -18)
📝 packages/hoppscotch-common/src/pages/e/_id.vue (+1 -1)

📄 Description

Closes HFE-355

Description

This PR fixes the issue in embeds where the 'system' theme choosed the app colour theme rather than the actual system theme

Checks

My pull request adheres to the code style of this project
My code requires changes to the documentation
I have updated the documentation as required
All the tests have passed

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3659 **Author:** [@nivedin](https://github.com/nivedin) **Created:** 12/15/2023 **Status:** ✅ Merged **Merged:** 12/16/2023 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `release/2023.12.0` ← **Head:** `fix/embeds-theme` --- ### 📝 Commits (3) - [`6e62ad5`](https://github.com/hoppscotch/hoppscotch/commit/6e62ad5977bbb0668e606347165e4990c9f5424f) fix: embeds system theme - [`b25997b`](https://github.com/hoppscotch/hoppscotch/commit/b25997b8303ddd40017c3a015d807e082fdb5c0e) refactor: minor change - [`4dabc7c`](https://github.com/hoppscotch/hoppscotch/commit/4dabc7cf0b3615ff525bcd975726a4c0d4d7b844) chore: add suggestions from review ### 📊 Changes **2 files changed** (+19 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/components/share/templates/Embeds.vue` (+18 -18) 📝 `packages/hoppscotch-common/src/pages/e/_id.vue` (+1 -1) </details> ### 📄 Description Closes HFE-355 ### Description This PR fixes the issue in embeds where the 'system' theme choosed the app colour theme rather than the actual system theme ### Checks - [x] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [ ] I have updated the documentation as required - [x] All the tests have passed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>