[PR #3656] [MERGED] refactor: improvements made to how banners are to be dismissed #4472

New issue

Closed

opened 2026-03-17 02:00:24 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:00:24 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3656
Author: @joeljstephen
Created: 12/15/2023
Status: ✅ Merged
Merged: 12/15/2023
Merged by: @AndrewBastin

Base: release/2023.12.0 ← Head: refactor/banner-improvements

📝 Commits (1)

ca3e55b refactor: changed the way banners are dismissed

📊 Changes

4 files changed (+6 additions, -2 deletions)

View changed files

📝 packages/hoppscotch-common/src/components/app/Banner.vue (+1 -1)
📝 packages/hoppscotch-common/src/components/app/Header.vue (+2 -1)
📝 packages/hoppscotch-common/src/services/banner.service.ts (+1 -0)
📝 packages/hoppscotch-sh-admin/src/components.d.ts (+2 -0)

📄 Description

Ticket

Closes HFE-354

Description

This PR focuses on improving how banners are dismissed. It is now a property of the banner which can be used by components using the banner.

Checks

My pull request adheres to the code style of this project
My code requires changes to the documentation
I have updated the documentation as required
All the tests have passed

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3656 **Author:** [@joeljstephen](https://github.com/joeljstephen) **Created:** 12/15/2023 **Status:** ✅ Merged **Merged:** 12/15/2023 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `release/2023.12.0` ← **Head:** `refactor/banner-improvements` --- ### 📝 Commits (1) - [`ca3e55b`](https://github.com/hoppscotch/hoppscotch/commit/ca3e55bd1449af57f22adb0b037bf0557b4165d4) refactor: changed the way banners are dismissed ### 📊 Changes **4 files changed** (+6 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/components/app/Banner.vue` (+1 -1) 📝 `packages/hoppscotch-common/src/components/app/Header.vue` (+2 -1) 📝 `packages/hoppscotch-common/src/services/banner.service.ts` (+1 -0) 📝 `packages/hoppscotch-sh-admin/src/components.d.ts` (+2 -0) </details> ### 📄 Description ### Ticket Closes HFE-354 ### Description This PR focuses on improving how banners are dismissed. It is now a property of the banner which can be used by components using the banner. ### Checks  - [x] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [ ] I have updated the documentation as required - [x] All the tests have passed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>