[PR #3657] [MERGED] refactor: embeds preview theme #4471

New issue

Closed

opened 2026-03-17 02:00:24 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:00:24 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3657
Author: @nivedin
Created: 12/15/2023
Status: ✅ Merged
Merged: 12/15/2023
Merged by: @AndrewBastin

Base: release/2023.12.0 ← Head: fix/embeds-bugs

📝 Commits (1)

d15c9e0 refactor: embeds preview theme

📊 Changes

1 file changed (+37 additions, -37 deletions)

View changed files

📝 packages/hoppscotch-common/src/components/share/templates/Embeds.vue (+37 -37)

📄 Description

Closes HFE-335

Description

This PR fixes the UI issue in embeds light mode preview when sharing a request.

Before

After

Checks

My pull request adheres to the code style of this project
My code requires changes to the documentation
I have updated the documentation as required
All the tests have passed

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3657 **Author:** [@nivedin](https://github.com/nivedin) **Created:** 12/15/2023 **Status:** ✅ Merged **Merged:** 12/15/2023 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `release/2023.12.0` ← **Head:** `fix/embeds-bugs` --- ### 📝 Commits (1) - [`d15c9e0`](https://github.com/hoppscotch/hoppscotch/commit/d15c9e0a43e0da17838188d38d385f372825a100) refactor: embeds preview theme ### 📊 Changes **1 file changed** (+37 additions, -37 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/components/share/templates/Embeds.vue` (+37 -37) </details> ### 📄 Description Closes HFE-335 ### Description This PR fixes the UI issue in embeds light mode preview when sharing a request. ### Before ![image](https://github.com/hoppscotch/hoppscotch/assets/53208152/a0b3a9a9-9d0a-406d-bff5-22a7e767b2e2) ### After ![image](https://github.com/hoppscotch/hoppscotch/assets/53208152/2761293b-a36c-4bb6-b947-72f79faa59c3) ### Checks - [x] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [ ] I have updated the documentation as required - [x] All the tests have passed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>