[PR #3651] [MERGED] fix: notify that the user is not an admin when trying to login with a non admin account in admin dashboard #4466

New issue

Closed

opened 2026-03-17 02:00:08 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:00:08 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3651
Author: @joeljstephen
Created: 12/14/2023
Status: ✅ Merged
Merged: 12/14/2023
Merged by: @AndrewBastin

Base: release/2023.12.0 ← Head: feat/dashboard-login-fix

📝 Commits (1)

9c8a746 refactor: notify user if he is logged in as non admin

📊 Changes

3 files changed (+5 additions, -2 deletions)

View changed files

📝 packages/hoppscotch-sh-admin/locales/en.json (+1 -1)
📝 packages/hoppscotch-sh-admin/src/components.d.ts (+0 -1)
📝 packages/hoppscotch-sh-admin/src/components/app/Login.vue (+4 -0)

📄 Description

Ticket

Closes HFE-349

Description

This PR fixes an issue where users where not notified that he/she is trying to login into the admin dashboard with a non admin account.

Checks

My pull request adheres to the code style of this project
My code requires changes to the documentation
I have updated the documentation as required
All the tests have passed

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3651 **Author:** [@joeljstephen](https://github.com/joeljstephen) **Created:** 12/14/2023 **Status:** ✅ Merged **Merged:** 12/14/2023 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `release/2023.12.0` ← **Head:** `feat/dashboard-login-fix` --- ### 📝 Commits (1) - [`9c8a746`](https://github.com/hoppscotch/hoppscotch/commit/9c8a746055bd6843aa832d31b71af7858805c82c) refactor: notify user if he is logged in as non admin ### 📊 Changes **3 files changed** (+5 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-sh-admin/locales/en.json` (+1 -1) 📝 `packages/hoppscotch-sh-admin/src/components.d.ts` (+0 -1) 📝 `packages/hoppscotch-sh-admin/src/components/app/Login.vue` (+4 -0) </details> ### 📄 Description ### Ticket Closes HFE-349 ### Description This PR fixes an issue where users where not notified that he/she is trying to login into the admin dashboard with a non admin account. ### Checks  - [x] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [ ] I have updated the documentation as required - [x] All the tests have passed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>