[PR #3630] [MERGED] fix(common): ensure banner colors are displayed correctly #4458

New issue

Closed

opened 2026-03-17 01:59:35 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 01:59:35 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3630
Author: @jamesgeorge007
Created: 12/6/2023
Status: ✅ Merged
Merged: 12/12/2023
Merged by: @AndrewBastin

Base: release/2023.12.0 ← Head: hotfix/banner-colors

📝 Commits (1)

755e0a4 fix: ensure banner colors are displayed correctly

📊 Changes

2 files changed (+3 additions, -3 deletions)

View changed files

📝 packages/hoppscotch-common/src/components/http/TestResult.vue (+1 -1)
📝 packages/hoppscotch-common/src/components/profile/UserDelete.vue (+2 -2)

📄 Description

Description

Banner color classes were updated in #3497. The old set of classes was referred to in a few places, and the banner color wasn't displayed correctly. This PR updates all the instances with the updated class names. It also includes fixes for errors raised by ESLint across the package.

Before

After

Checks

My pull request adheres to the code style of this project
All the tests have passed

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3630 **Author:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Created:** 12/6/2023 **Status:** ✅ Merged **Merged:** 12/12/2023 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `release/2023.12.0` ← **Head:** `hotfix/banner-colors` --- ### 📝 Commits (1) - [`755e0a4`](https://github.com/hoppscotch/hoppscotch/commit/755e0a441edd4ed3d6e7a9b030fa95680a31edb2) fix: ensure banner colors are displayed correctly ### 📊 Changes **2 files changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/components/http/TestResult.vue` (+1 -1) 📝 `packages/hoppscotch-common/src/components/profile/UserDelete.vue` (+2 -2) </details> ### 📄 Description ### Description Banner color classes were updated in #3497. The old set of classes was referred to in a few places, and the banner color wasn't displayed correctly. This PR updates all the instances with the updated class names. It also includes fixes for errors raised by ESLint across the package. ### Before ![image](https://github.com/hoppscotch/hoppscotch/assets/25279263/b420cf8b-a65b-4894-85c4-71861ae9d477) ![image](https://github.com/hoppscotch/hoppscotch/assets/25279263/2fd797b9-6c10-41b7-bb54-57ab0c8f7e39) ### After ![image](https://github.com/hoppscotch/hoppscotch/assets/25279263/8e15037d-1f8a-423f-a161-9dfd5d830541) ![image](https://github.com/hoppscotch/hoppscotch/assets/25279263/9471cbf6-38a4-447f-9c86-bc351a8ba4ff) ### Checks - [x] My pull request adheres to the code style of this project - [x] All the tests have passed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>