[PR #3588] [MERGED] fix: email validation failure in cases when email entered is correct when trying to create a team in admin dashboard #4438

New issue

Closed

opened 2026-03-17 01:58:29 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 01:58:29 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3588
Author: @joeljstephen
Created: 11/23/2023
Status: ✅ Merged
Merged: 11/29/2023
Merged by: @AndrewBastin

Base: release/2023.12.0 ← Head: fix/dashboard-team-email-validation

📝 Commits (3)

52c4a5b fix: two way binding in smart auto complete
fce863e refactor: reset owner email only when modal exists
35a0ffb fix: dynamically bind the value for type attribute

📊 Changes

4 files changed (+31 additions, -7 deletions)

View changed files

📝 packages/hoppscotch-sh-admin/src/components.d.ts (+5 -0)
📝 packages/hoppscotch-sh-admin/src/components/teams/Add.vue (+11 -4)
📝 packages/hoppscotch-sh-admin/src/pages/teams/index.vue (+1 -1)
📝 packages/hoppscotch-ui/src/components/smart/AutoComplete.vue (+14 -2)

📄 Description

Ticket

Closes HFE-325
Fixes #3581

Description

This PR focuses on fixing an issue where in few cases, email validation fails when trying to enter the email address of the owner of the team to be created, even when the email address entered is correct. This PR also brings a fix to SmartAutoComplete component to refine and improve the two way binding of data, with the component invoking the autocomplete UI component.

Objectives

Fix two way binding problems in SmartAutoComplete component.
Fix an issue where email validation sometimes fails even though the email address entered is correct when creating a team.

Checks

My pull request adheres to the code style of this project
My code requires changes to the documentation
I have updated the documentation as required
All the tests have passed

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3588 **Author:** [@joeljstephen](https://github.com/joeljstephen) **Created:** 11/23/2023 **Status:** ✅ Merged **Merged:** 11/29/2023 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `release/2023.12.0` ← **Head:** `fix/dashboard-team-email-validation` --- ### 📝 Commits (3) - [`52c4a5b`](https://github.com/hoppscotch/hoppscotch/commit/52c4a5b36ea36b6105f60680aaf32cef235a846a) fix: two way binding in smart auto complete - [`fce863e`](https://github.com/hoppscotch/hoppscotch/commit/fce863eee974e78a59620154119f2c3664a73cc5) refactor: reset owner email only when modal exists - [`35a0ffb`](https://github.com/hoppscotch/hoppscotch/commit/35a0ffba891b0ecf2e8efa4ecef1f371e2556723) fix: dynamically bind the value for type attribute ### 📊 Changes **4 files changed** (+31 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-sh-admin/src/components.d.ts` (+5 -0) 📝 `packages/hoppscotch-sh-admin/src/components/teams/Add.vue` (+11 -4) 📝 `packages/hoppscotch-sh-admin/src/pages/teams/index.vue` (+1 -1) 📝 `packages/hoppscotch-ui/src/components/smart/AutoComplete.vue` (+14 -2) </details> ### 📄 Description ### Ticket - Closes HFE-325 - Fixes #3581 ### Description This PR focuses on fixing an issue where in few cases, email validation fails when trying to enter the email address of the owner of the team to be created, even when the email address entered is correct. This PR also brings a fix to SmartAutoComplete component to refine and improve the two way binding of data, with the component invoking the autocomplete UI component. ### Objectives - [x] Fix two way binding problems in SmartAutoComplete component. - [x] Fix an issue where email validation sometimes fails even though the email address entered is correct when creating a team. ### Checks  - [x] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [ ] I have updated the documentation as required - [x] All the tests have passed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>