[PR #3573] bug: remove mandatory client secret variable #4436

Open
opened 2026-03-17 01:58:29 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3573
Author: @Dan6erbond
Created: 11/21/2023
Status: 🔄 Open

Base: mainHead: bug/3572-allow-client-secret-for-oauth2-authentication


📝 Commits (1)

  • ec7d9fe bug: remove mandatory client secret variable

📊 Changes

1 file changed (+0 additions, -4 deletions)

View changed files

📝 packages/hoppscotch-common/src/helpers/oauth.ts (+0 -4)

📄 Description

Closes #3572

Description

Removes client secret validation to trigger client credentials flow when it isn't set.

Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

Additional Information

None.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3573 **Author:** [@Dan6erbond](https://github.com/Dan6erbond) **Created:** 11/21/2023 **Status:** 🔄 Open **Base:** `main` ← **Head:** `bug/3572-allow-client-secret-for-oauth2-authentication` --- ### 📝 Commits (1) - [`ec7d9fe`](https://github.com/hoppscotch/hoppscotch/commit/ec7d9fe6bcd5be4fe04e4a8fa4d8f3cddda27017) bug: remove mandatory client secret variable ### 📊 Changes **1 file changed** (+0 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/helpers/oauth.ts` (+0 -4) </details> ### 📄 Description <!-- Thanks for creating this pull request 🤗 Please make sure that the pull request is limited to one type (docs, feature, etc.) and keep it as small as possible. You can open multiple prs instead of opening a huge one. --> <!-- If this pull request closes an issue, please mention the issue number below --> Closes #3572 ### Description <!-- Add a brief description of the pull request --> <!-- You can also choose to add a list of changes and if they have been completed or not by using the markdown to-do list syntax - [ ] Not Completed - [x] Completed --> Removes client secret validation to trigger client credentials flow when it isn't set. ### Checks <!-- Make sure your pull request passes the CI checks and do check the following fields as needed - --> - [x] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [x] I have updated the documentation as required - [x] All the tests have passed ### Additional Information <!-- Any additional information like breaking changes, dependencies added, screenshots, comparisons between new and old behaviour, etc. --> None. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#4436
No description provided.