[PR #3541] [CLOSED] chore: Remove whitespace in env variables #4424

New issue

Closed

opened 2026-03-17 01:57:40 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 01:57:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3541
Author: @dantehemerson
Created: 11/13/2023
Status: ❌ Closed

Base: release/2023.12.0 ← Head: chore/remove-whitespace-in-variable

📝 Commits (10+)

16044b5 feat: desktop app
a13c2fd chore: pin @codemirror/language to 6.9.0
97bd808 chore: set versions with a bump version
05d2175 fix: selfhost-desktop not running gql-codegen
736f83a fix: header inspector cookie inspection will not trigger if current interceptor supports cookies
6631348 feat: let platforms disable we are using cookies prompt
be3e5ba fix: graphql query deprecation issue (#3506)
bb8dc6f chore: updated brand assets (#3500)
2bd925d chore: correct version of selfhost-desktop
9d1d369 fix: performance issues due to mouse on header detection

📊 Changes

173 files changed (+12421 additions, -361 deletions)

View changed files

📝 .env.example (+2 -2)
📝 packages/codemirror-lang-graphql/package.json (+1 -1)
📝 packages/hoppscotch-backend/package.json (+1 -1)
📝 packages/hoppscotch-common/locales/en.json (+21 -1)
📝 packages/hoppscotch-common/package.json (+7 -3)
➕ packages/hoppscotch-common/public/badge-dark.svg (+1 -0)
➕ packages/hoppscotch-common/public/badge-light.svg (+1 -0)
📝 packages/hoppscotch-common/public/banner.png (+0 -0)
📝 packages/hoppscotch-common/public/favicon.ico (+0 -0)
📝 packages/hoppscotch-common/public/icon.png (+0 -0)
📝 packages/hoppscotch-common/public/icons/pwa-1024x1024.png (+0 -0)
📝 packages/hoppscotch-common/public/icons/pwa-128x128.png (+0 -0)
📝 packages/hoppscotch-common/public/icons/pwa-16x16.png (+0 -0)
📝 packages/hoppscotch-common/public/icons/pwa-192x192.png (+0 -0)
📝 packages/hoppscotch-common/public/icons/pwa-256x256.png (+0 -0)
📝 packages/hoppscotch-common/public/icons/pwa-32x32.png (+0 -0)
📝 packages/hoppscotch-common/public/icons/pwa-512x512.png (+0 -0)
📝 packages/hoppscotch-common/public/images/banner-dark.png (+0 -0)
📝 packages/hoppscotch-common/public/images/banner-light.png (+0 -0)
📝 packages/hoppscotch-common/public/logo.png (+0 -0)

...and 80 more files

📄 Description

Description

I was getting this error while running the app due to extra whitespace in the env. This PR remove extra whitespaces, so the users only have to change the values in their env file.

Checks

My pull request adheres to the code style of this project
My code requires changes to the documentation
I have updated the documentation as required
All the tests have passed

Additional Information

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3541 **Author:** [@dantehemerson](https://github.com/dantehemerson) **Created:** 11/13/2023 **Status:** ❌ Closed **Base:** `release/2023.12.0` ← **Head:** `chore/remove-whitespace-in-variable` --- ### 📝 Commits (10+) - [`16044b5`](https://github.com/hoppscotch/hoppscotch/commit/16044b58405f67215da9380bb804afda3fded50a) feat: desktop app - [`a13c2fd`](https://github.com/hoppscotch/hoppscotch/commit/a13c2fd4c123826dd92e56ee252b5fd1d45bea26) chore: pin @codemirror/language to 6.9.0 - [`97bd808`](https://github.com/hoppscotch/hoppscotch/commit/97bd80843103b03ba19aa47e73721467b1d037f0) chore: set versions with a bump version - [`05d2175`](https://github.com/hoppscotch/hoppscotch/commit/05d2175f43a70e6f5f63e668a5768b31657e1c19) fix: selfhost-desktop not running gql-codegen - [`736f83a`](https://github.com/hoppscotch/hoppscotch/commit/736f83a70c9aaab78bd6d6d984fec8f2eeffb53b) fix: header inspector cookie inspection will not trigger if current interceptor supports cookies - [`6631348`](https://github.com/hoppscotch/hoppscotch/commit/663134839fdd7eaeef76f3bd148f4e4842790025) feat: let platforms disable we are using cookies prompt - [`be3e5ba`](https://github.com/hoppscotch/hoppscotch/commit/be3e5ba7e7b8359ce8f386eda8b9f3769e1ff28a) fix: graphql query deprecation issue (#3506) - [`bb8dc6f`](https://github.com/hoppscotch/hoppscotch/commit/bb8dc6f7ebdc95d1b482d164b0ddcfe151893e01) chore: updated brand assets (#3500) - [`2bd925d`](https://github.com/hoppscotch/hoppscotch/commit/2bd925d441ac82c4cd13d337ec71ed4f7e0b07f9) chore: correct version of selfhost-desktop - [`9d1d369`](https://github.com/hoppscotch/hoppscotch/commit/9d1d369f37300e78f7fcb40ec001630718e1f60b) fix: performance issues due to mouse on header detection ### 📊 Changes **173 files changed** (+12421 additions, -361 deletions) <details> <summary>View changed files</summary> 📝 `.env.example` (+2 -2) 📝 `packages/codemirror-lang-graphql/package.json` (+1 -1) 📝 `packages/hoppscotch-backend/package.json` (+1 -1) 📝 `packages/hoppscotch-common/locales/en.json` (+21 -1) 📝 `packages/hoppscotch-common/package.json` (+7 -3) ➕ `packages/hoppscotch-common/public/badge-dark.svg` (+1 -0) ➕ `packages/hoppscotch-common/public/badge-light.svg` (+1 -0) 📝 `packages/hoppscotch-common/public/banner.png` (+0 -0) 📝 `packages/hoppscotch-common/public/favicon.ico` (+0 -0) 📝 `packages/hoppscotch-common/public/icon.png` (+0 -0) 📝 `packages/hoppscotch-common/public/icons/pwa-1024x1024.png` (+0 -0) 📝 `packages/hoppscotch-common/public/icons/pwa-128x128.png` (+0 -0) 📝 `packages/hoppscotch-common/public/icons/pwa-16x16.png` (+0 -0) 📝 `packages/hoppscotch-common/public/icons/pwa-192x192.png` (+0 -0) 📝 `packages/hoppscotch-common/public/icons/pwa-256x256.png` (+0 -0) 📝 `packages/hoppscotch-common/public/icons/pwa-32x32.png` (+0 -0) 📝 `packages/hoppscotch-common/public/icons/pwa-512x512.png` (+0 -0) 📝 `packages/hoppscotch-common/public/images/banner-dark.png` (+0 -0) 📝 `packages/hoppscotch-common/public/images/banner-light.png` (+0 -0) 📝 `packages/hoppscotch-common/public/logo.png` (+0 -0) _...and 80 more files_ </details> ### 📄 Description  ### Description  I was getting this error while running the app due to extra whitespace in the env. This PR remove extra whitespaces, so the users only have to change the values in their env file. <img width="651" alt="Screenshot 2023-11-13 at 12 51 08 AM" src="https://github.com/hoppscotch/hoppscotch/assets/18385321/296157be-5971-4e13-a84b-ae4ef6f42d62">  ### Checks  - [x] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [ ] I have updated the documentation as required - [x] All the tests have passed ### Additional Information  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>