[PR #3509] [MERGED] fix(common): parentheses and single quotes support to curl imports #4417

New issue

Closed

opened 2026-03-17 01:57:24 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 01:57:24 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3509
Author: @ajmalmohad
Created: 11/8/2023
Status: ✅ Merged
Merged: 12/4/2023
Merged by: @AndrewBastin

Base: release/2023.12.0 ← Head: bug/unrecognized-chars-curl

📝 Commits (1)

c147e8e fix(common): parentheses and single quotes support to curl

📊 Changes

1 file changed (+6 additions, -1 deletions)

View changed files

📝 packages/hoppscotch-common/src/helpers/curl/sub_helpers/url.ts (+6 -1)

📄 Description

Closes #3485

Description

Added parentheses and single quotes support to importing from curl. Changed the regex to include the parentheses and single quotes. Before that the single quotes existing at the start and end of URL are removed using replace(/^'|'$/g, ""). Also ran a lint fix.

Checks

My pull request adheres to the code style of this project
My code requires changes to the documentation
I have updated the documentation as required
All the tests have passed

Additional Information

Screencast from 08-11-23 09:45:44 PM IST.webm

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3509 **Author:** [@ajmalmohad](https://github.com/ajmalmohad) **Created:** 11/8/2023 **Status:** ✅ Merged **Merged:** 12/4/2023 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `release/2023.12.0` ← **Head:** `bug/unrecognized-chars-curl` --- ### 📝 Commits (1) - [`c147e8e`](https://github.com/hoppscotch/hoppscotch/commit/c147e8ec549f3397b52723b64099e6ebdb807edf) fix(common): parentheses and single quotes support to curl ### 📊 Changes **1 file changed** (+6 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/helpers/curl/sub_helpers/url.ts` (+6 -1) </details> ### 📄 Description   Closes #3485 ### Description Added parentheses and single quotes support to importing from curl. Changed the regex to include the parentheses and single quotes. Before that the single quotes existing at the start and end of URL are removed using `replace(/^'|'$/g, "")`. Also ran a lint fix.  ### Checks  - [x] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [ ] I have updated the documentation as required - [x] All the tests have passed ### Additional Information [Screencast from 08-11-23 09:45:44 PM IST.webm](https://github.com/hoppscotch/hoppscotch/assets/55492635/106f9057-24e1-48b2-a70d-ba98615d3674) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>