mirror of
https://github.com/hoppscotch/hoppscotch.git
synced 2026-04-26 09:16:03 +03:00
[PR #3475] [MERGED] fix: mailer template issue #4398
Labels
No labels
CodeDay
a11y
browser limited
bug
bug fix
cli
core
critical
design
desktop
discussion
docker
documentation
duplicate
enterprise
feature
feature
fosshack
future
good first issue
hacktoberfest
help wanted
i18n
invalid
major
minor
need information
need testing
not applicable to hoppscotch
not reproducible
pull-request
question
refactor
resolved
sandbox
self-host
spam
stale
testmu
wip
wont fix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hoppscotch#4398
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/hoppscotch/hoppscotch/pull/3475
Author: @balub
Created: 10/25/2023
Status: ✅ Merged
Merged: 11/6/2023
Merged by: @AndrewBastin
Base:
release/2023.8.3← Head:fix/nodemailer-templates-issue📝 Commits (4)
feabd00chore: moved templates folder to hoppscotch-backend root53644dechore: changed target to prod in hoppscotch-old-backend service173c456chore: renamed code-your-own.hbs template to user-invitation.hbs6d35688chore: changed name of template to user-invitation📊 Changes
6 files changed (+62 additions, -62 deletions)
View changed files
📝
packages/hoppscotch-backend/src/admin/admin.service.ts(+1 -1)📝
packages/hoppscotch-backend/src/auth/auth.service.ts(+1 -1)📝
packages/hoppscotch-backend/src/mailer/MailDescriptions.ts(+2 -2)📝
packages/hoppscotch-backend/src/mailer/mailer.service.ts(+1 -1)📝
packages/hoppscotch-backend/src/mailer/templates/team-invitation.hbs(+57 -57)📝
packages/hoppscotch-backend/src/mailer/templates/user-invitation.hbs(+0 -0)📄 Description
Closes HBE-304
Description
In this PR, we fix a known issue with the mailer module where the
templatesfolder is not present in thedistfolder after the image has been built.Checks
Testing info
Make sure to build the image using the following command, with the necessary changes.
Check if the following type of emails are being sent correctly using
mailcatcher:🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
typefield inrestTabStateschema #4781