[PR #3475] [MERGED] fix: mailer template issue #4398

Closed
opened 2026-03-17 01:56:17 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3475
Author: @balub
Created: 10/25/2023
Status: Merged
Merged: 11/6/2023
Merged by: @AndrewBastin

Base: release/2023.8.3Head: fix/nodemailer-templates-issue


📝 Commits (4)

  • feabd00 chore: moved templates folder to hoppscotch-backend root
  • 53644de chore: changed target to prod in hoppscotch-old-backend service
  • 173c456 chore: renamed code-your-own.hbs template to user-invitation.hbs
  • 6d35688 chore: changed name of template to user-invitation

📊 Changes

6 files changed (+62 additions, -62 deletions)

View changed files

📝 packages/hoppscotch-backend/src/admin/admin.service.ts (+1 -1)
📝 packages/hoppscotch-backend/src/auth/auth.service.ts (+1 -1)
📝 packages/hoppscotch-backend/src/mailer/MailDescriptions.ts (+2 -2)
📝 packages/hoppscotch-backend/src/mailer/mailer.service.ts (+1 -1)
📝 packages/hoppscotch-backend/src/mailer/templates/team-invitation.hbs (+57 -57)
📝 packages/hoppscotch-backend/src/mailer/templates/user-invitation.hbs (+0 -0)

📄 Description

Closes HBE-304

Description

In this PR, we fix a known issue with the mailer module where the templates folder is not present in the dist folder after the image has been built.

Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

Testing info

Make sure to build the image using the following command, with the necessary changes.

docker build -t hoppscotch-local-aio -f prod.Dockerfile --target aio .

Check if the following type of emails are being sent correctly using mailcatcher:

  • User-Invitations from the admin app.
  • Team-Invitation for the app.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3475 **Author:** [@balub](https://github.com/balub) **Created:** 10/25/2023 **Status:** ✅ Merged **Merged:** 11/6/2023 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `release/2023.8.3` ← **Head:** `fix/nodemailer-templates-issue` --- ### 📝 Commits (4) - [`feabd00`](https://github.com/hoppscotch/hoppscotch/commit/feabd00d30a1c197655cb7b742c328bd5f5c6d41) chore: moved templates folder to hoppscotch-backend root - [`53644de`](https://github.com/hoppscotch/hoppscotch/commit/53644de8515a394bc6b6881dd82850b89b9b650d) chore: changed target to prod in hoppscotch-old-backend service - [`173c456`](https://github.com/hoppscotch/hoppscotch/commit/173c456eb717448252119659a2657ad56020645a) chore: renamed code-your-own.hbs template to user-invitation.hbs - [`6d35688`](https://github.com/hoppscotch/hoppscotch/commit/6d35688f27b8dc66aeee8a5ea82d5dd86016bf1d) chore: changed name of template to user-invitation ### 📊 Changes **6 files changed** (+62 additions, -62 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-backend/src/admin/admin.service.ts` (+1 -1) 📝 `packages/hoppscotch-backend/src/auth/auth.service.ts` (+1 -1) 📝 `packages/hoppscotch-backend/src/mailer/MailDescriptions.ts` (+2 -2) 📝 `packages/hoppscotch-backend/src/mailer/mailer.service.ts` (+1 -1) 📝 `packages/hoppscotch-backend/src/mailer/templates/team-invitation.hbs` (+57 -57) 📝 `packages/hoppscotch-backend/src/mailer/templates/user-invitation.hbs` (+0 -0) </details> ### 📄 Description <!-- Thanks for creating this pull request 🤗 Please make sure that the pull request is limited to one type (docs, feature, etc.) and keep it as small as possible. You can open multiple prs instead of opening a huge one. --> <!-- If this pull request closes an issue, please mention the issue number below --> Closes HBE-304 ### Description <!-- Add a brief description of the pull request --> In this PR, we fix a known issue with the mailer module where the `templates` folder is not present in the `dist` folder after the image has been built. <!-- You can also choose to add a list of changes and if they have been completed or not by using the markdown to-do list syntax - [ ] Not Completed - [x] Completed --> ### Checks <!-- Make sure your pull request passes the CI checks and do check the following fields as needed - --> - [x] My pull request adheres to the code style of this project - [x] My code requires changes to the documentation - [ ] I have updated the documentation as required - [x] All the tests have passed ### Testing info Make sure to build the image using the following command, with the necessary changes. ``` docker build -t hoppscotch-local-aio -f prod.Dockerfile --target aio . ``` Check if the following type of emails are being sent correctly using `mailcatcher`: - User-Invitations from the admin app. - Team-Invitation for the app. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-17 01:56:17 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#4398
No description provided.