[PR #3476] [MERGED] feat: introduction of shared-requests #4397

New issue

Closed

opened 2026-03-17 01:56:17 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 01:56:17 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3476
Author: @balub
Created: 10/26/2023
Status: ✅ Merged
Merged: 11/7/2023
Merged by: @balub

Base: release/2023.12.0 ← Head: feat/shared-requests

📝 Commits (10+)

28a8875 feat: added new property to existing shortcode model in prisma schema
12f2840 chore: created shared-requests module
f149582 chore: created shared-request model
7876c42 chore: complete sharedRequest query
b74c1ab chore: completed mutation to create a SharedRequest
b7462ab chore: completed subscription to create a SharedRequest
d56224b chore: completed query to fetch all user created shared-requests
6023ee2 chore: completed mutation to delete a SharedRequest
1124ba1 chore: completed subscription to delete a SharedRequest
a1b9523 chore: removed unused dependncues in share-requests module

📊 Changes

9 files changed (+381 additions, -125 deletions)

View changed files

➕ packages/hoppscotch-backend/prisma/migrations/20231106120154_embeds_addition/migration.sql (+15 -0)
📝 packages/hoppscotch-backend/prisma/schema.prisma (+8 -5)
📝 packages/hoppscotch-backend/src/errors.ts (+21 -12)
📝 packages/hoppscotch-backend/src/pubsub/topicsDefs.ts (+3 -1)
📝 packages/hoppscotch-backend/src/shortcode/shortcode.model.ts (+7 -1)
📝 packages/hoppscotch-backend/src/shortcode/shortcode.module.ts (+1 -9)
📝 packages/hoppscotch-backend/src/shortcode/shortcode.resolver.ts (+48 -10)
📝 packages/hoppscotch-backend/src/shortcode/shortcode.service.spec.ts (+205 -72)
📝 packages/hoppscotch-backend/src/shortcode/shortcode.service.ts (+73 -15)

📄 Description

Closes HBE-289

Description

In this PR we introduce a property to the existing Shortcode type called properties. This properties property will be used to store all data related to an embed, which is a new feature addition in the 2023.12.0 release. The Shortcode type will now have the following properties

type Shortcodes {
	id: ID!
	request: String!
	properties: String?
	createdOn: DateTime!
}

Checks

My pull request adheres to the code style of this project
My code requires changes to the documentation
I have updated the documentation as required
All the tests have passed

Additional Information

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3476 **Author:** [@balub](https://github.com/balub) **Created:** 10/26/2023 **Status:** ✅ Merged **Merged:** 11/7/2023 **Merged by:** [@balub](https://github.com/balub) **Base:** `release/2023.12.0` ← **Head:** `feat/shared-requests` --- ### 📝 Commits (10+) - [`28a8875`](https://github.com/hoppscotch/hoppscotch/commit/28a88759c613126e31e356b8402de03b0d858254) feat: added new property to existing shortcode model in prisma schema - [`12f2840`](https://github.com/hoppscotch/hoppscotch/commit/12f2840013a527c93f25924a38e2b42c6f45a2b8) chore: created shared-requests module - [`f149582`](https://github.com/hoppscotch/hoppscotch/commit/f149582a62931b764845d6b01489fc30d73b6dea) chore: created shared-request model - [`7876c42`](https://github.com/hoppscotch/hoppscotch/commit/7876c42312e4efe9b422c32567736a955a955a63) chore: complete sharedRequest query - [`b74c1ab`](https://github.com/hoppscotch/hoppscotch/commit/b74c1abf6fbb491bef6c5dbaae8877199fe2345a) chore: completed mutation to create a SharedRequest - [`b7462ab`](https://github.com/hoppscotch/hoppscotch/commit/b7462ab014951c331698d5f8cabc5a708c076228) chore: completed subscription to create a SharedRequest - [`d56224b`](https://github.com/hoppscotch/hoppscotch/commit/d56224b17bdeb0915f35a5dba5fb7155a0c3285a) chore: completed query to fetch all user created shared-requests - [`6023ee2`](https://github.com/hoppscotch/hoppscotch/commit/6023ee27cf543a26be944280ac0bdeb9fc9b276d) chore: completed mutation to delete a SharedRequest - [`1124ba1`](https://github.com/hoppscotch/hoppscotch/commit/1124ba1ba369ba799ac882570ef7a73bd2b0baa8) chore: completed subscription to delete a SharedRequest - [`a1b9523`](https://github.com/hoppscotch/hoppscotch/commit/a1b952329bc1605ca28f79847546ff45ad1daa5d) chore: removed unused dependncues in share-requests module ### 📊 Changes **9 files changed** (+381 additions, -125 deletions) <details> <summary>View changed files</summary> ➕ `packages/hoppscotch-backend/prisma/migrations/20231106120154_embeds_addition/migration.sql` (+15 -0) 📝 `packages/hoppscotch-backend/prisma/schema.prisma` (+8 -5) 📝 `packages/hoppscotch-backend/src/errors.ts` (+21 -12) 📝 `packages/hoppscotch-backend/src/pubsub/topicsDefs.ts` (+3 -1) 📝 `packages/hoppscotch-backend/src/shortcode/shortcode.model.ts` (+7 -1) 📝 `packages/hoppscotch-backend/src/shortcode/shortcode.module.ts` (+1 -9) 📝 `packages/hoppscotch-backend/src/shortcode/shortcode.resolver.ts` (+48 -10) 📝 `packages/hoppscotch-backend/src/shortcode/shortcode.service.spec.ts` (+205 -72) 📝 `packages/hoppscotch-backend/src/shortcode/shortcode.service.ts` (+73 -15) </details> ### 📄 Description   Closes HBE-289 ### Description  In this PR we introduce a property to the existing `Shortcode` type called `properties`. This `properties` property will be used to store all data related to an embed, which is a new feature addition in the `2023.12.0` release. The `Shortcode` type will now have the following properties ``` type Shortcodes { id: ID! request: String! properties: String? createdOn: DateTime! } ```  ### Checks  - [x] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [ ] I have updated the documentation as required - [x] All the tests have passed ### Additional Information  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>