mirror of
https://github.com/hoppscotch/hoppscotch.git
synced 2026-04-26 01:06:00 +03:00
[PR #3466] [MERGED] feat(common): display status text from the API response if available #4393
Labels
No labels
CodeDay
a11y
browser limited
bug
bug fix
cli
core
critical
design
desktop
discussion
docker
documentation
duplicate
enterprise
feature
feature
fosshack
future
good first issue
hacktoberfest
help wanted
i18n
invalid
major
minor
need information
need testing
not applicable to hoppscotch
not reproducible
pull-request
question
refactor
resolved
sandbox
self-host
spam
stale
testmu
wip
wont fix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hoppscotch#4393
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/hoppscotch/hoppscotch/pull/3466
Author: @kpguru20001
Created: 10/21/2023
Status: ✅ Merged
Merged: 12/4/2023
Merged by: @AndrewBastin
Base:
release/2023.12.0← Head:feature/display-statusText-#3458📝 Commits (4)
4e2bf1fdocs(Common): 📝 an RFC document to explain the PR and its relevant changes9799b7bfeat(Common): ✨ pass statusText from axios res to hoppRestResponse and displaybca368afix(PR-Comments): 🐛 removed console logs and dead code files48dd94erefactor: eliminate redundancy📊 Changes
5 files changed (+25 additions, -4 deletions)
View changed files
📝
packages/hoppscotch-common/src/components/http/ResponseMeta.vue(+6 -1)📝
packages/hoppscotch-common/src/helpers/network.ts(+1 -1)📝
packages/hoppscotch-common/src/helpers/types/HoppRESTResponse.ts(+2 -1)📝
packages/hoppscotch-common/src/helpers/utils/statusCodes.ts(+12 -1)📝
packages/hoppscotch-common/src/services/inspection/inspectors/__tests__/response.inspector.spec.ts(+4 -0)📄 Description
Closes #3458
Description
As requested as a feature this PR is aimed to pass statusText from response and display it in place of the Hoppscotch Response.
Checks
Additional Information
BREAKING CHANGE:
Not sure if it i breaking anything at an API level but the type defn. of
HoppRESTResponsedefined inpackages/hoppscotch-common/src/helpers/types/HoppRESTResponse.tshas been updated to request statusText as a mandatory field.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.