[PR #3460] [MERGED] fix(self-hosted/web): add "useCredentials: true" to Vite PWA options #4392

Closed
opened 2026-03-17 01:56:01 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3460
Author: @superbiche
Created: 10/18/2023
Status: Merged
Merged: 11/1/2023
Merged by: @AndrewBastin

Base: release/2023.8.3Head: fix/pwa-use-credentials


📝 Commits (1)

  • bfeaee2 Add "useCredentials: true" to Vite PWA options

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 packages/hoppscotch-selfhost-web/vite.config.ts (+1 -0)

📄 Description

Description

Set useCredentials: true in Vite PWA options to prevent 401 errors when accessing the app with a basic HTTP auth.

When using a Basic HTTP Authentication, Google Chrome reports 401 errors when trying to fetch the manifest:
image

Vite PWA docs FAQ recommend to use the useCredentials option: https://vite-pwa-org.netlify.app/guide/faq.html#web-app-manifest-and-401-status-code-unauthorized.

This PR does only that.

Checks

  • My pull request adheres to the code style of this project
  • My code does not require changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

Additional Information

This should have no impact except avoiding 401 errors for the manifest.

A workaround is to open the manifest file in a new tab, then reload the UI, but having this option would make it much easier.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3460 **Author:** [@superbiche](https://github.com/superbiche) **Created:** 10/18/2023 **Status:** ✅ Merged **Merged:** 11/1/2023 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `release/2023.8.3` ← **Head:** `fix/pwa-use-credentials` --- ### 📝 Commits (1) - [`bfeaee2`](https://github.com/hoppscotch/hoppscotch/commit/bfeaee2b3ff7ab2c08057001f97f0a145d74b3fd) Add "useCredentials: true" to Vite PWA options ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-selfhost-web/vite.config.ts` (+1 -0) </details> ### 📄 Description ### Description Set useCredentials: true in Vite PWA options to prevent 401 errors when accessing the app with a basic HTTP auth. When using a Basic HTTP Authentication, Google Chrome reports 401 errors when trying to fetch the manifest: ![image](https://github.com/hoppscotch/hoppscotch/assets/2478146/760a24b3-ba16-4e91-a860-274eb5ad54c3) Vite PWA docs FAQ recommend to use the `useCredentials` option: https://vite-pwa-org.netlify.app/guide/faq.html#web-app-manifest-and-401-status-code-unauthorized. This PR does only that. ### Checks <!-- Make sure your pull request passes the CI checks and do check the following fields as needed - --> - [x] My pull request adheres to the code style of this project - [x] My code **does not** require changes to the documentation - [x] I have updated the documentation as required - [x] All the tests have passed ### Additional Information This should have no impact except avoiding 401 errors for the manifest. A workaround is to open the manifest file in a new tab, then reload the UI, but having this option would make it much easier. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-17 01:56:01 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#4392
No description provided.