[PR #3448] [MERGED] fix(common): use tab service within helpers #4382

New issue

Closed

opened 2026-03-17 01:55:28 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 01:55:28 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3448
Author: @jamesgeorge007
Created: 10/12/2023
Status: ✅ Merged
Merged: 10/12/2023
Merged by: @AndrewBastin

Base: release/2023.8.2 ← Head: hotfix/tab-service

📝 Commits (1)

e0afe2b fix: use tab service within helpers

📊 Changes

1 file changed (+8 additions, -3 deletions)

View changed files

📝 packages/hoppscotch-common/src/helpers/graphql/connection.ts (+8 -3)

📄 Description

Description

With #3367, we moved away from helpers for tab-related functionalities to a service. However, there was a stale import that led to the build failure. This PR fixes it by replacing it with the service implementation. It also organizes imports used in the file.

Checks

My pull request adheres to the code style of this project
All the tests have passed

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3448 **Author:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Created:** 10/12/2023 **Status:** ✅ Merged **Merged:** 10/12/2023 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `release/2023.8.2` ← **Head:** `hotfix/tab-service` --- ### 📝 Commits (1) - [`e0afe2b`](https://github.com/hoppscotch/hoppscotch/commit/e0afe2bd3f69432fa946967774e8bf9f4a485f98) fix: use tab service within helpers ### 📊 Changes **1 file changed** (+8 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/helpers/graphql/connection.ts` (+8 -3) </details> ### 📄 Description ### Description With #3367, we moved away from helpers for tab-related functionalities to a service. However, there was a stale import that led to the build failure. This PR fixes it by replacing it with the service implementation. It also organizes imports used in the file. ### Checks - [x] My pull request adheres to the code style of this project - [x] All the tests have passed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>