[PR #3416] [MERGED] feat(common): alert the user on empty collection/environment exports #4377

New issue

Closed

opened 2026-03-17 01:55:11 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 01:55:11 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3416
Author: @jamesgeorge007
Created: 10/4/2023
Status: ✅ Merged
Merged: 10/5/2023
Merged by: @AndrewBastin

Base: release/2023.8.2 ← Head: feat/alert-on-empty-export

📝 Commits (1)

cebac9c feat: alert the user on empty collection/environment exports

📊 Changes

4 files changed (+22 additions, -0 deletions)

View changed files

📝 packages/hoppscotch-common/locales/en.json (+2 -0)
📝 packages/hoppscotch-common/src/components/collections/graphql/ImportExport.vue (+7 -0)
📝 packages/hoppscotch-common/src/components/collections/index.vue (+6 -0)
📝 packages/hoppscotch-common/src/components/environments/ImportExport.vue (+7 -0)

📄 Description

Description

Exporting is allowed regardless of collection/environment entries, resulting in an empty json file being downloaded. This PR aims to show an error toast when no collections or environments exist and the user attempts to export.

Fixes HP-166.

Preview

https://github.com/hoppscotch/hoppscotch/assets/25279263/c2be565b-69cb-42aa-ada4-fe675d3848a9

Checks

My pull request adheres to the code style of this project
All the tests have passed

Additional Information

Appreciate any suggestions to improvise the toast message.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3416 **Author:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Created:** 10/4/2023 **Status:** ✅ Merged **Merged:** 10/5/2023 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `release/2023.8.2` ← **Head:** `feat/alert-on-empty-export` --- ### 📝 Commits (1) - [`cebac9c`](https://github.com/hoppscotch/hoppscotch/commit/cebac9cc44201f53b791e1be92d157b80a22ee85) feat: alert the user on empty collection/environment exports ### 📊 Changes **4 files changed** (+22 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/locales/en.json` (+2 -0) 📝 `packages/hoppscotch-common/src/components/collections/graphql/ImportExport.vue` (+7 -0) 📝 `packages/hoppscotch-common/src/components/collections/index.vue` (+6 -0) 📝 `packages/hoppscotch-common/src/components/environments/ImportExport.vue` (+7 -0) </details> ### 📄 Description ### Description Exporting is allowed regardless of collection/environment entries, resulting in an empty `json` file being downloaded. This PR aims to show an error toast when no collections or environments exist and the user attempts to export. Fixes HP-166. ## Preview https://github.com/hoppscotch/hoppscotch/assets/25279263/c2be565b-69cb-42aa-ada4-fe675d3848a9 ### Checks - [x] My pull request adheres to the code style of this project - [x] All the tests have passed ### Additional Information Appreciate any suggestions to improvise the toast message. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>