[PR #3418] [MERGED] fix(selfhost-web): environment variables usage in meta tags #4376

New issue

Closed

opened 2026-03-17 01:55:11 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 01:55:11 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3418
Author: @jamesgeorge007
Created: 10/4/2023
Status: ✅ Merged
Merged: 10/5/2023
Merged by: @AndrewBastin

Base: release/2023.8.2 ← Head: hotfix/meta-env-vars

📝 Commits (1)

13e058f fix: environment variables usage in meta tags

📊 Changes

1 file changed (+4 additions, -4 deletions)

View changed files

📝 packages/hoppscotch-selfhost-web/meta.ts (+4 -4)

📄 Description

Description

Currently, the content attribute for meta tags with the following name attributes resolves to undefined since they don't follow the expected format while referring to the base URL environment variable.

Fixes HFE-258.

image
og:image
twitter:image
msapplication-TileImage

This PR aims at fixing the usage across the meta entry definitions.

Checks

My pull request adheres to the code style of this project
All the tests have passed

Additional Information

Verified the meta previews on opengraph.xyz.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3418 **Author:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Created:** 10/4/2023 **Status:** ✅ Merged **Merged:** 10/5/2023 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `release/2023.8.2` ← **Head:** `hotfix/meta-env-vars` --- ### 📝 Commits (1) - [`13e058f`](https://github.com/hoppscotch/hoppscotch/commit/13e058f0c682e8b5d4eff0645c464f33d943949f) fix: environment variables usage in meta tags ### 📊 Changes **1 file changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-selfhost-web/meta.ts` (+4 -4) </details> ### 📄 Description ### Description Currently, the `content` attribute for meta tags with the following name attributes resolves to `undefined` since they don't follow the expected format while referring to the base URL environment variable. Fixes HFE-258. - `image` - `og:image` - `twitter:image` - `msapplication-TileImage` This PR aims at fixing the usage across the meta entry definitions. ### Checks - [x] My pull request adheres to the code style of this project - [x] All the tests have passed ### Additional Information Verified the meta previews on [opengraph.xyz](https://www.opengraph.xyz/). ![meta-preview](https://github.com/hoppscotch/hoppscotch/assets/25279263/6261c219-8805-4bdc-8049-d28324f420e0) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>