mirror of
https://github.com/hoppscotch/hoppscotch.git
synced 2026-04-25 16:55:59 +03:00
[PR #3395] [MERGED] refactor: updated i18n implementation in the admin dashboard #4370
Labels
No labels
CodeDay
a11y
browser limited
bug
bug fix
cli
core
critical
design
desktop
discussion
docker
documentation
duplicate
enterprise
feature
feature
fosshack
future
good first issue
hacktoberfest
help wanted
i18n
invalid
major
minor
need information
need testing
not applicable to hoppscotch
not reproducible
pull-request
question
refactor
resolved
sandbox
self-host
spam
stale
testmu
wip
wont fix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hoppscotch#4370
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/hoppscotch/hoppscotch/pull/3395
Author: @joeljstephen
Created: 9/27/2023
Status: ✅ Merged
Merged: 10/6/2023
Merged by: @AndrewBastin
Base:
release/2023.8.2← Head:refactor/update-i18n-implementation📝 Commits (3)
b3b34b7feat: introduced new unplugin i18n and removed the old vite i18n package6f3c0d3refactor: updated vite config to support the new plugin71dc0d5refactor: removed irrelevant logic from the i18n module📊 Changes
4 files changed (+135 additions, -210 deletions)
View changed files
📝
packages/hoppscotch-sh-admin/package.json(+1 -1)📝
packages/hoppscotch-sh-admin/src/modules/i18n.ts(+5 -143)📝
packages/hoppscotch-sh-admin/vite.config.ts(+17 -20)📝
pnpm-lock.yaml(+112 -46)📄 Description
Ticket
Description
This PR focuses on updating the i18n implementation of the Admin Dashboard. It was using a similar i18n implementation that was used by the app. However, most of the features were irrelevant to the Dashboard. The new implementation has a simpler logic and introduces the
unplugin-vue-i18nto the Dashboard. It also aims to fix the missing translations issue faced by few users in production.Objectives
Checks
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.