[PR #3395] [MERGED] refactor: updated i18n implementation in the admin dashboard #4370

Closed
opened 2026-03-17 01:54:39 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3395
Author: @joeljstephen
Created: 9/27/2023
Status: Merged
Merged: 10/6/2023
Merged by: @AndrewBastin

Base: release/2023.8.2Head: refactor/update-i18n-implementation


📝 Commits (3)

  • b3b34b7 feat: introduced new unplugin i18n and removed the old vite i18n package
  • 6f3c0d3 refactor: updated vite config to support the new plugin
  • 71dc0d5 refactor: removed irrelevant logic from the i18n module

📊 Changes

4 files changed (+135 additions, -210 deletions)

View changed files

📝 packages/hoppscotch-sh-admin/package.json (+1 -1)
📝 packages/hoppscotch-sh-admin/src/modules/i18n.ts (+5 -143)
📝 packages/hoppscotch-sh-admin/vite.config.ts (+17 -20)
📝 pnpm-lock.yaml (+112 -46)

📄 Description

Ticket

  • Closes HFE-233
  • Fixes #3343
  • Partially Fixes #3349

Description

This PR focuses on updating the i18n implementation of the Admin Dashboard. It was using a similar i18n implementation that was used by the app. However, most of the features were irrelevant to the Dashboard. The new implementation has a simpler logic and introduces the unplugin-vue-i18n to the Dashboard. It also aims to fix the missing translations issue faced by few users in production.

Objectives

  • Fix missing translation issues on the Admin Dashboard
  • Simplify the i18n implementation in the Admin Dashboard

Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3395 **Author:** [@joeljstephen](https://github.com/joeljstephen) **Created:** 9/27/2023 **Status:** ✅ Merged **Merged:** 10/6/2023 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `release/2023.8.2` ← **Head:** `refactor/update-i18n-implementation` --- ### 📝 Commits (3) - [`b3b34b7`](https://github.com/hoppscotch/hoppscotch/commit/b3b34b7d142ac5e73b1744805825bd514024a88b) feat: introduced new unplugin i18n and removed the old vite i18n package - [`6f3c0d3`](https://github.com/hoppscotch/hoppscotch/commit/6f3c0d3b4f88d5eda1ac2b46541b46385d8c7088) refactor: updated vite config to support the new plugin - [`71dc0d5`](https://github.com/hoppscotch/hoppscotch/commit/71dc0d596065e54b78ba4f6336defbf3edbf70b9) refactor: removed irrelevant logic from the i18n module ### 📊 Changes **4 files changed** (+135 additions, -210 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-sh-admin/package.json` (+1 -1) 📝 `packages/hoppscotch-sh-admin/src/modules/i18n.ts` (+5 -143) 📝 `packages/hoppscotch-sh-admin/vite.config.ts` (+17 -20) 📝 `pnpm-lock.yaml` (+112 -46) </details> ### 📄 Description ### Ticket - Closes HFE-233 - Fixes #3343 - Partially Fixes #3349 ### Description This PR focuses on updating the i18n implementation of the Admin Dashboard. It was using a similar i18n implementation that was used by the app. However, most of the features were irrelevant to the Dashboard. The new implementation has a simpler logic and introduces the `unplugin-vue-i18n` to the Dashboard. It also aims to fix the missing translations issue faced by few users in production. ### Objectives - [x] Fix missing translation issues on the Admin Dashboard - [x] Simplify the i18n implementation in the Admin Dashboard ### Checks <!-- Make sure your pull request passes the CI checks and do check the following fields as needed - --> - [x] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [ ] I have updated the documentation as required - [x] All the tests have passed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-17 01:54:39 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#4370
No description provided.