mirror of
https://github.com/hoppscotch/hoppscotch.git
synced 2026-04-25 16:55:59 +03:00
[PR #3351] [MERGED] fix: sticky searchbar hidden in codemirror #4352
Labels
No labels
CodeDay
a11y
browser limited
bug
bug fix
cli
core
critical
design
desktop
discussion
docker
documentation
duplicate
enterprise
feature
feature
fosshack
future
good first issue
hacktoberfest
help wanted
i18n
invalid
major
minor
need information
need testing
not applicable to hoppscotch
not reproducible
pull-request
question
refactor
resolved
sandbox
self-host
spam
stale
testmu
wip
wont fix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hoppscotch#4352
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/hoppscotch/hoppscotch/pull/3351
Author: @nivedin
Created: 9/13/2023
Status: ✅ Merged
Merged: 9/18/2023
Merged by: @AndrewBastin
Base:
release/2023.8.1← Head:fix/sticky-searchbar-codemirror📝 Commits (4)
6225017fix: sticky search bar in codemirror44664afchore: use tailwind classes030632dchore: clean upe571d10chore: improve consistency across editor instances📊 Changes
22 files changed (+172 additions, -23 deletions)
View changed files
📝
packages/hoppscotch-common/assets/scss/styles.scss(+16 -0)📝
packages/hoppscotch-common/assets/scss/themes.scss(+2 -0)📝
packages/hoppscotch-common/src/components.d.ts(+1 -0)📝
packages/hoppscotch-common/src/components/graphql/RequestOptions.vue(+6 -0)📝
packages/hoppscotch-common/src/components/graphql/Response.vue(+6 -0)📝
packages/hoppscotch-common/src/components/graphql/Sidebar.vue(+6 -0)📝
packages/hoppscotch-common/src/components/http/Headers.vue(+6 -0)📝
packages/hoppscotch-common/src/components/http/Parameters.vue(+6 -0)📝
packages/hoppscotch-common/src/components/http/PreRequestScript.vue(+6 -0)📝
packages/hoppscotch-common/src/components/http/RawBody.vue(+6 -0)📝
packages/hoppscotch-common/src/components/http/Tests.vue(+6 -0)📝
packages/hoppscotch-common/src/components/http/URLEncodedParams.vue(+6 -0)📝
packages/hoppscotch-common/src/components/lenses/renderers/JSONLensRenderer.vue(+13 -1)📝
packages/hoppscotch-common/src/components/lenses/renderers/RawLensRenderer.vue(+6 -0)📝
packages/hoppscotch-common/src/components/realtime/Communication.vue(+18 -1)📝
packages/hoppscotch-common/src/components/smart/EnvInput.vue(+17 -2)📝
packages/hoppscotch-common/src/composables/codemirror.ts(+2 -2)📝
packages/hoppscotch-common/src/helpers/editor/themes/baseTheme.ts(+38 -16)📝
packages/hoppscotch-common/src/pages/realtime/socketio.vue(+1 -0)📝
packages/hoppscotch-common/src/pages/realtime/websocket.vue(+1 -0)...and 2 more files
📄 Description
Closes #3240
Closes HFE-211
Description
This PR fixes the issue in code mirror instances where the search panel gets hidden when scrolling because of the sticky nature of the components above it.
Checks
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.