[PR #3351] [MERGED] fix: sticky searchbar hidden in codemirror #4352

Closed
opened 2026-03-17 01:53:50 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3351
Author: @nivedin
Created: 9/13/2023
Status: Merged
Merged: 9/18/2023
Merged by: @AndrewBastin

Base: release/2023.8.1Head: fix/sticky-searchbar-codemirror


📝 Commits (4)

  • 6225017 fix: sticky search bar in codemirror
  • 44664af chore: use tailwind classes
  • 030632d chore: clean up
  • e571d10 chore: improve consistency across editor instances

📊 Changes

22 files changed (+172 additions, -23 deletions)

View changed files

📝 packages/hoppscotch-common/assets/scss/styles.scss (+16 -0)
📝 packages/hoppscotch-common/assets/scss/themes.scss (+2 -0)
📝 packages/hoppscotch-common/src/components.d.ts (+1 -0)
📝 packages/hoppscotch-common/src/components/graphql/RequestOptions.vue (+6 -0)
📝 packages/hoppscotch-common/src/components/graphql/Response.vue (+6 -0)
📝 packages/hoppscotch-common/src/components/graphql/Sidebar.vue (+6 -0)
📝 packages/hoppscotch-common/src/components/http/Headers.vue (+6 -0)
📝 packages/hoppscotch-common/src/components/http/Parameters.vue (+6 -0)
📝 packages/hoppscotch-common/src/components/http/PreRequestScript.vue (+6 -0)
📝 packages/hoppscotch-common/src/components/http/RawBody.vue (+6 -0)
📝 packages/hoppscotch-common/src/components/http/Tests.vue (+6 -0)
📝 packages/hoppscotch-common/src/components/http/URLEncodedParams.vue (+6 -0)
📝 packages/hoppscotch-common/src/components/lenses/renderers/JSONLensRenderer.vue (+13 -1)
📝 packages/hoppscotch-common/src/components/lenses/renderers/RawLensRenderer.vue (+6 -0)
📝 packages/hoppscotch-common/src/components/realtime/Communication.vue (+18 -1)
📝 packages/hoppscotch-common/src/components/smart/EnvInput.vue (+17 -2)
📝 packages/hoppscotch-common/src/composables/codemirror.ts (+2 -2)
📝 packages/hoppscotch-common/src/helpers/editor/themes/baseTheme.ts (+38 -16)
📝 packages/hoppscotch-common/src/pages/realtime/socketio.vue (+1 -0)
📝 packages/hoppscotch-common/src/pages/realtime/websocket.vue (+1 -0)

...and 2 more files

📄 Description

Closes #3240
Closes HFE-211

Description

This PR fixes the issue in code mirror instances where the search panel gets hidden when scrolling because of the sticky nature of the components above it.

Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3351 **Author:** [@nivedin](https://github.com/nivedin) **Created:** 9/13/2023 **Status:** ✅ Merged **Merged:** 9/18/2023 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `release/2023.8.1` ← **Head:** `fix/sticky-searchbar-codemirror` --- ### 📝 Commits (4) - [`6225017`](https://github.com/hoppscotch/hoppscotch/commit/622501726cf0d900b0ce122b079a6d0847588323) fix: sticky search bar in codemirror - [`44664af`](https://github.com/hoppscotch/hoppscotch/commit/44664af93c11f6720db8ba97cb59c124a0ec0276) chore: use tailwind classes - [`030632d`](https://github.com/hoppscotch/hoppscotch/commit/030632d141554294e339b32349e94bc908086cd6) chore: clean up - [`e571d10`](https://github.com/hoppscotch/hoppscotch/commit/e571d101ae7d4abaf178fa293efbf8dae59bdd45) chore: improve consistency across editor instances ### 📊 Changes **22 files changed** (+172 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/assets/scss/styles.scss` (+16 -0) 📝 `packages/hoppscotch-common/assets/scss/themes.scss` (+2 -0) 📝 `packages/hoppscotch-common/src/components.d.ts` (+1 -0) 📝 `packages/hoppscotch-common/src/components/graphql/RequestOptions.vue` (+6 -0) 📝 `packages/hoppscotch-common/src/components/graphql/Response.vue` (+6 -0) 📝 `packages/hoppscotch-common/src/components/graphql/Sidebar.vue` (+6 -0) 📝 `packages/hoppscotch-common/src/components/http/Headers.vue` (+6 -0) 📝 `packages/hoppscotch-common/src/components/http/Parameters.vue` (+6 -0) 📝 `packages/hoppscotch-common/src/components/http/PreRequestScript.vue` (+6 -0) 📝 `packages/hoppscotch-common/src/components/http/RawBody.vue` (+6 -0) 📝 `packages/hoppscotch-common/src/components/http/Tests.vue` (+6 -0) 📝 `packages/hoppscotch-common/src/components/http/URLEncodedParams.vue` (+6 -0) 📝 `packages/hoppscotch-common/src/components/lenses/renderers/JSONLensRenderer.vue` (+13 -1) 📝 `packages/hoppscotch-common/src/components/lenses/renderers/RawLensRenderer.vue` (+6 -0) 📝 `packages/hoppscotch-common/src/components/realtime/Communication.vue` (+18 -1) 📝 `packages/hoppscotch-common/src/components/smart/EnvInput.vue` (+17 -2) 📝 `packages/hoppscotch-common/src/composables/codemirror.ts` (+2 -2) 📝 `packages/hoppscotch-common/src/helpers/editor/themes/baseTheme.ts` (+38 -16) 📝 `packages/hoppscotch-common/src/pages/realtime/socketio.vue` (+1 -0) 📝 `packages/hoppscotch-common/src/pages/realtime/websocket.vue` (+1 -0) _...and 2 more files_ </details> ### 📄 Description Closes #3240 Closes HFE-211 ### Description This PR fixes the issue in code mirror instances where the search panel gets hidden when scrolling because of the sticky nature of the components above it. ### Checks - [x] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [ ] I have updated the documentation as required - [x] All the tests have passed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-17 01:53:50 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#4352
No description provided.