[PR #3332] [MERGED] refactor: keyboard shortcuts now supports different keyboard layouts including Dvorak #4341

New issue

Closed

opened 2026-03-17 01:53:17 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 01:53:17 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3332
Author: @joeljstephen
Created: 9/8/2023
Status: ✅ Merged
Merged: 9/8/2023
Merged by: @AndrewBastin

Base: release/2023.8.1 ← Head: refactor/support-keyboard-layouts

📝 Commits (2)

25a095e refactor: support mulitple keyboard layouts such as dvorak
c04d9f3 chore: replace redundant variable usage

📊 Changes

1 file changed (+11 additions, -11 deletions)

View changed files

📝 packages/hoppscotch-common/src/helpers/keybindings.ts (+11 -11)

📄 Description

Ticket

Closes HFE-219
Fixes #3322
Suppressed #3314

Description

This PR focuses on allowing the keyboard shortcuts in the app to support different keyboard layouts by using the unique key code parameter. This has been tested with QWERTY and DVORAK Keyboard Layouts and it works as expected.

Objectives

Keyboard shortcuts should support DVORAK layout
Example: CMD/CTRL - C used to reset the request when using DVORAK Layout which has now been resolved. Only CMD/CTRL - I resets the request connection on both QWERTY and DVORAK Layouts

Checks

My pull request adheres to the code style of this project
My code requires changes to the documentation
I have updated the documentation as required
All the tests have passed

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3332 **Author:** [@joeljstephen](https://github.com/joeljstephen) **Created:** 9/8/2023 **Status:** ✅ Merged **Merged:** 9/8/2023 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `release/2023.8.1` ← **Head:** `refactor/support-keyboard-layouts` --- ### 📝 Commits (2) - [`25a095e`](https://github.com/hoppscotch/hoppscotch/commit/25a095e765ed1701f3e5c26d89fa9a608ac910ea) refactor: support mulitple keyboard layouts such as dvorak - [`c04d9f3`](https://github.com/hoppscotch/hoppscotch/commit/c04d9f35b22b3222e265e6fbac510fa606746831) chore: replace redundant variable usage ### 📊 Changes **1 file changed** (+11 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/helpers/keybindings.ts` (+11 -11) </details> ### 📄 Description ### Ticket - Closes HFE-219 - Fixes #3322 - Suppressed #3314 ### Description This PR focuses on allowing the keyboard shortcuts in the app to support different keyboard layouts by using the unique key code parameter. This has been tested with QWERTY and DVORAK Keyboard Layouts and it works as expected. ### Objectives - [x] Keyboard shortcuts should support DVORAK layout - Example: `CMD/CTRL - C` used to reset the request when using DVORAK Layout which has now been resolved. Only `CMD/CTRL - I` resets the request connection on both QWERTY and DVORAK Layouts ### Checks  - [x] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [ ] I have updated the documentation as required - [x] All the tests have passed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>