[PR #3294] [MERGED] HBE-258 hotfix: skip parameter in findMany in shortcode module #4328

New issue

Closed

opened 2026-03-17 01:52:28 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 01:52:28 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3294
Author: @mirarifhasan
Created: 8/25/2023
Status: ✅ Merged
Merged: 8/25/2023
Merged by: @AndrewBastin

Base: release/2023.8.0 ← Head: hotfix/fetch-shortcode

📝 Commits (1)

5649052 fix: skip parameter in findMany

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 packages/hoppscotch-backend/src/shortcode/shortcode.service.ts (+1 -1)

📄 Description

Closes HBE-258

Description

This hotfix PR solves the fetch shortcode issue. When the request comes for fetchUserShortCodes, the this.prisma.shortcode.findMany skip the first data (in default). The correct logic should be, the there is cursor parameter in arg (for pagination), only that time skip: 1 should pass in the findMany() operation.

Checks

My pull request adheres to the code style of this project
My code requires changes to the documentation
I have updated the documentation as required
All the tests have passed

Additional Information

Nil

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3294 **Author:** [@mirarifhasan](https://github.com/mirarifhasan) **Created:** 8/25/2023 **Status:** ✅ Merged **Merged:** 8/25/2023 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `release/2023.8.0` ← **Head:** `hotfix/fetch-shortcode` --- ### 📝 Commits (1) - [`5649052`](https://github.com/hoppscotch/hoppscotch/commit/564905222ce9549d8477737f37ced7c4db8d64dc) fix: skip parameter in findMany ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-backend/src/shortcode/shortcode.service.ts` (+1 -1) </details> ### 📄 Description    Closes HBE-258 ### Description  This hotfix PR solves the fetch shortcode issue. When the request comes for fetchUserShortCodes, the `this.prisma.shortcode.findMany` skip the first data (in default). The correct logic should be, the there is cursor parameter in arg (for pagination), only that time `skip: 1` should pass in the findMany() operation.  ### Checks  - [x] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [ ] I have updated the documentation as required - [ ] All the tests have passed ### Additional Information  Nil --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>