[PR #3280] [MERGED] fix: fix issues in displaying the suggestions menu on EnvInput #4323

New issue

Closed

opened 2026-03-17 01:52:12 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 01:52:12 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3280
Author: @amk-dev
Created: 8/23/2023
Status: ✅ Merged
Merged: 8/23/2023
Merged by: @AndrewBastin

Base: release/2023.8.0 ← Head: fix/issues-with-showing-env-input-suggestions

📝 Commits (1)

f65c5b3 fix: fix issues with click-outside on EnvInput

📊 Changes

1 file changed (+3 additions, -2 deletions)

View changed files

📝 packages/hoppscotch-common/src/components/smart/EnvInput.vue (+3 -2)

📄 Description

fixs HFE-148

Before

Suggestions menu was not displayed when the EnvInput was focused.

We had an onClickOutside handler defined for suggestionsMenu, it hides the suggestions menu.
But the input div was outside of this suggestions menu, causing the onClickOutside handler to run everytime someone clicked on the input div, which infact hid the suggestions menu.

After

Suggestions menu is displayed properly. moved the onClickOutside to target the autoCompleteWrapper instead of the suggestions menu.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3280 **Author:** [@amk-dev](https://github.com/amk-dev) **Created:** 8/23/2023 **Status:** ✅ Merged **Merged:** 8/23/2023 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `release/2023.8.0` ← **Head:** `fix/issues-with-showing-env-input-suggestions` --- ### 📝 Commits (1) - [`f65c5b3`](https://github.com/hoppscotch/hoppscotch/commit/f65c5b3caf70d6a6075cd5f79a89cf6d0963df52) fix: fix issues with click-outside on EnvInput ### 📊 Changes **1 file changed** (+3 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/components/smart/EnvInput.vue` (+3 -2) </details> ### 📄 Description fixs HFE-148 **Before** Suggestions menu was not displayed when the EnvInput was focused. We had an `onClickOutside` handler defined for suggestionsMenu, it hides the suggestions menu. But the input div was outside of this suggestions menu, causing the onClickOutside handler to run everytime someone clicked on the input div, which infact hid the suggestions menu. **After** Suggestions menu is displayed properly. moved the onClickOutside to target the `autoCompleteWrapper` instead of the suggestions menu. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>