[PR #3276] [MERGED] fix: vertical scroll not working on codemirror instance when lines are not wrapped #4317

Closed
opened 2026-03-17 01:51:55 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3276
Author: @amk-dev
Created: 8/23/2023
Status: Merged
Merged: 8/23/2023
Merged by: @AndrewBastin

Base: release/2023.8.0Head: fix/vertical-scroll-codemirror


📝 Commits (2)

  • 532af29 fix: fix codemirror vertical scroll not working when lines are not wrapped
  • 8a33527 refactor: use utlity classes

📊 Changes

3 files changed (+12 additions, -0 deletions)

View changed files

📝 packages/hoppscotch-common/assets/scss/styles.scss (+4 -0)
📝 packages/hoppscotch-sh-admin/assets/scss/styles.scss (+4 -0)
📝 packages/hoppscotch-ui/src/assets/scss/styles.scss (+4 -0)

📄 Description

fixs HFE-149

Before

Vertical scroll was not working when line wrap is disabled on codemirror instances.

After

Now the scroll works as intented. recently we introduced a overscroll-bahaviour: none to the wildcard selector ( * ). this change was causing the trouble with the codemirror instances. so we override this rule for the .cm-scroller. this way the codemirror instances are not affected by the overscroll-bahaviour: none anymore.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3276 **Author:** [@amk-dev](https://github.com/amk-dev) **Created:** 8/23/2023 **Status:** ✅ Merged **Merged:** 8/23/2023 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `release/2023.8.0` ← **Head:** `fix/vertical-scroll-codemirror` --- ### 📝 Commits (2) - [`532af29`](https://github.com/hoppscotch/hoppscotch/commit/532af29701c928f19aa7268c64ac1e9e114c0126) fix: fix codemirror vertical scroll not working when lines are not wrapped - [`8a33527`](https://github.com/hoppscotch/hoppscotch/commit/8a335276acf90064cfc26f3afeafe24ebefc3575) refactor: use utlity classes ### 📊 Changes **3 files changed** (+12 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/assets/scss/styles.scss` (+4 -0) 📝 `packages/hoppscotch-sh-admin/assets/scss/styles.scss` (+4 -0) 📝 `packages/hoppscotch-ui/src/assets/scss/styles.scss` (+4 -0) </details> ### 📄 Description fixs HFE-149 **Before** Vertical scroll was not working when line wrap is disabled on codemirror instances. **After** Now the scroll works as intented. recently we introduced a `overscroll-bahaviour: none` to the wildcard selector ( * ). this change was causing the trouble with the codemirror instances. so we override this rule for the `.cm-scroller`. this way the codemirror instances are not affected by the `overscroll-bahaviour: none` anymore. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-17 01:51:55 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#4317
No description provided.