mirror of
https://github.com/hoppscotch/hoppscotch.git
synced 2026-04-26 01:06:00 +03:00
[PR #3276] [MERGED] fix: vertical scroll not working on codemirror instance when lines are not wrapped #4317
Labels
No labels
CodeDay
a11y
browser limited
bug
bug fix
cli
core
critical
design
desktop
discussion
docker
documentation
duplicate
enterprise
feature
feature
fosshack
future
good first issue
hacktoberfest
help wanted
i18n
invalid
major
minor
need information
need testing
not applicable to hoppscotch
not reproducible
pull-request
question
refactor
resolved
sandbox
self-host
spam
stale
testmu
wip
wont fix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hoppscotch#4317
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/hoppscotch/hoppscotch/pull/3276
Author: @amk-dev
Created: 8/23/2023
Status: ✅ Merged
Merged: 8/23/2023
Merged by: @AndrewBastin
Base:
release/2023.8.0← Head:fix/vertical-scroll-codemirror📝 Commits (2)
532af29fix: fix codemirror vertical scroll not working when lines are not wrapped8a33527refactor: use utlity classes📊 Changes
3 files changed (+12 additions, -0 deletions)
View changed files
📝
packages/hoppscotch-common/assets/scss/styles.scss(+4 -0)📝
packages/hoppscotch-sh-admin/assets/scss/styles.scss(+4 -0)📝
packages/hoppscotch-ui/src/assets/scss/styles.scss(+4 -0)📄 Description
fixs HFE-149
Before
Vertical scroll was not working when line wrap is disabled on codemirror instances.
After
Now the scroll works as intented. recently we introduced a
overscroll-bahaviour: noneto the wildcard selector ( * ). this change was causing the trouble with the codemirror instances. so we override this rule for the.cm-scroller. this way the codemirror instances are not affected by theoverscroll-bahaviour: noneanymore.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.