mirror of
https://github.com/hoppscotch/hoppscotch.git
synced 2026-04-25 16:55:59 +03:00
[PR #3204] [MERGED] feat: dynamically select which auth providers for your instance of Hoppscotch (BE implementation) #4283
Labels
No labels
CodeDay
a11y
browser limited
bug
bug fix
cli
core
critical
design
desktop
discussion
docker
documentation
duplicate
enterprise
feature
feature
fosshack
future
good first issue
hacktoberfest
help wanted
i18n
invalid
major
minor
need information
need testing
not applicable to hoppscotch
not reproducible
pull-request
question
refactor
resolved
sandbox
self-host
spam
stale
testmu
wip
wont fix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hoppscotch#4283
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/hoppscotch/hoppscotch/pull/3204
Author: @balub
Created: 7/21/2023
Status: ✅ Merged
Merged: 8/3/2023
Merged by: @balub
Base:
release/2023.8.0← Head:feat/conditional-auth-select📝 Commits (10+)
6928eb7feat(lang): update tw translation (#3170)25177bdfix: update vite-plugin-dts version which fixes build issue on docker/alpine (#3179)82b6e08fix: fixed issue in team-environment test cases (#3189)9402bb9fix: add healthcheck for db and remove unwanted volumes (#3150)51efb35fix: keybinding modifier issue (#3163)3984255fix: reduce the memory consumption during build to prevent OOM (#3148)6496beachore: bump version to 2023.4.8e869d49chore: run tests on and against release branches29171d1fix: generate-ui failing to build48356cbfeat: social auth providers can now be conditionally provisioned📊 Changes
28 files changed (+413 additions, -228 deletions)
View changed files
➕
.dockerignore(+1 -0)📝
.env.example(+1 -0)📝
.github/workflows/tests.yml(+2 -2)📝
docker-compose.yml(+13 -3)📝
packages/hoppscotch-backend/package.json(+1 -1)📝
packages/hoppscotch-backend/src/auth/auth.controller.ts(+11 -2)📝
packages/hoppscotch-backend/src/auth/auth.module.ts(+4 -3)📝
packages/hoppscotch-backend/src/auth/guards/github-sso.guard.ts(+14 -2)📝
packages/hoppscotch-backend/src/auth/guards/google-sso.guard.ts(+14 -2)📝
packages/hoppscotch-backend/src/auth/guards/microsoft-sso-.guard.ts(+20 -2)📝
packages/hoppscotch-backend/src/auth/helper.ts(+32 -2)📝
packages/hoppscotch-backend/src/errors.ts(+24 -0)📝
packages/hoppscotch-backend/src/main.ts(+3 -0)📝
packages/hoppscotch-backend/src/team-environments/team-environments.service.spec.ts(+2 -2)📝
packages/hoppscotch-backend/src/utils.ts(+30 -1)📝
packages/hoppscotch-common/locales/tw.json(+58 -58)📝
packages/hoppscotch-common/package.json(+1 -1)➕
packages/hoppscotch-common/public/badge.svg(+1 -0)📝
packages/hoppscotch-common/src/components.d.ts(+0 -21)📝
packages/hoppscotch-common/src/helpers/keybindings.ts(+18 -11)...and 8 more files
📄 Description
Closes HP-70 & HBE-224
Closes #3088 and #3211.
Description
In this PR, we allow users to select now the auth providers they would like to use in their instance of Hoppscotch. Previously the user had no option but to configure all the providers however from now we have the following changes:
ALLOWED_AUTH_PROVIDERS, this env variable contains a comma-separated list of all the providers the user would like to use in the format specified below.ALLOWED_AUTH_PROVIDERS = GOOGLE,GITHUB,MICROSOFT,EMAILALLOWED_AUTH_PROVIDERSenv variable.Checks
Additional Information
EMAILrefers to the magic link.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.