[PR #3174] [MERGED] fix: email not being checked case insensitive on team invitation acceptance #4267

New issue

Closed

opened 2026-03-17 01:49:11 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 01:49:11 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3174
Author: @AndrewBastin
Created: 7/6/2023
Status: ✅ Merged
Merged: 7/11/2023
Merged by: @AndrewBastin

Base: release/2023.4.8 ← Head: bug/team-invite-email

📝 Commits (1)

83c25cf fix: email not being checked case insensitive on team invitation

📊 Changes

2 files changed (+5 additions, -3 deletions)

View changed files

📝 packages/hoppscotch-backend/src/team-invitation/team-invitation.service.ts (+3 -1)
📝 packages/hoppscotch-backend/src/team-invitation/team-invitee.guard.ts (+2 -2)

📄 Description

Closes HBE-238

Description

This PR deals with a tiny bug in the team invitation acceptance logic and TeamInviteeGuard on how they compare if two emails are equal.

In the places fixed by this PR, they were compared in a case-sensitive way, but generally emails should be compared in case-insensitive as many email servers do normalise it to lowercase (even though it is not specified as such in the Email Spec).

Checks

My pull request adheres to the code style of this project
My code requires changes to the documentation
I have updated the documentation as required
All the tests have passed

Additional Information

N/A

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3174 **Author:** [@AndrewBastin](https://github.com/AndrewBastin) **Created:** 7/6/2023 **Status:** ✅ Merged **Merged:** 7/11/2023 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `release/2023.4.8` ← **Head:** `bug/team-invite-email` --- ### 📝 Commits (1) - [`83c25cf`](https://github.com/hoppscotch/hoppscotch/commit/83c25cf512cce7e7b1a18f87fb471e249801f1d5) fix: email not being checked case insensitive on team invitation ### 📊 Changes **2 files changed** (+5 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-backend/src/team-invitation/team-invitation.service.ts` (+3 -1) 📝 `packages/hoppscotch-backend/src/team-invitation/team-invitee.guard.ts` (+2 -2) </details> ### 📄 Description Closes HBE-238 ### Description This PR deals with a tiny bug in the team invitation acceptance logic and `TeamInviteeGuard` on how they compare if two emails are equal. In the places fixed by this PR, they were compared in a case-sensitive way, but generally emails should be compared in case-insensitive as many email servers do normalise it to lowercase (even though it is not specified as such in the Email Spec). ### Checks - [x] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [x] I have updated the documentation as required - [x] All the tests have passed ### Additional Information N/A --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>