[PR #3152] [MERGED] fix: use --location param for url when parsing curl #4253

New issue

Closed

opened 2026-03-17 01:48:22 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 01:48:22 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3152
Author: @amk-dev
Created: 6/19/2023
Status: ✅ Merged
Merged: 6/22/2023
Merged by: @AndrewBastin

Base: release/2023.4.7 ← Head: fix/hfe-77

📝 Commits (3)

ef24178 fix: fix issue parsing location with curl
80ad513 fix: fix reactivity issues with RequestOptions
2bfd781 refactor: use useVModel for request

📊 Changes

3 files changed (+7 additions, -12 deletions)

View changed files

📝 packages/hoppscotch-common/src/components/http/Headers.vue (+1 -1)
📝 packages/hoppscotch-common/src/components/http/RequestOptions.vue (+3 -10)
📝 packages/hoppscotch-common/src/helpers/curl/sub_helpers/url.ts (+3 -1)

📄 Description

Fixes #3109

Url is not properly parsed when importing using curl

Before

We were not respecting the --location parameter when parsing the curl request.

After

Respect the --location parameter when parsing the curl request.

Body And Headers are not loaded properly

Before

In component RequestOptions.vue, we have a ref request which is set to props.modelValue in the setup function. but when the component updates with new props, this is not updated. this caused child components that uses this request ref to not get updated reactively.

After

Added a watcher that updates the request ref, when the props change.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3152 **Author:** [@amk-dev](https://github.com/amk-dev) **Created:** 6/19/2023 **Status:** ✅ Merged **Merged:** 6/22/2023 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `release/2023.4.7` ← **Head:** `fix/hfe-77` --- ### 📝 Commits (3) - [`ef24178`](https://github.com/hoppscotch/hoppscotch/commit/ef24178dec104f5d7d16ed7849c9bf3d9550d367) fix: fix issue parsing location with curl - [`80ad513`](https://github.com/hoppscotch/hoppscotch/commit/80ad51348512fd676057155e43346dfde328d9de) fix: fix reactivity issues with RequestOptions - [`2bfd781`](https://github.com/hoppscotch/hoppscotch/commit/2bfd78189a86c8584343674991952b2a4f7a62ea) refactor: use useVModel for request ### 📊 Changes **3 files changed** (+7 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/components/http/Headers.vue` (+1 -1) 📝 `packages/hoppscotch-common/src/components/http/RequestOptions.vue` (+3 -10) 📝 `packages/hoppscotch-common/src/helpers/curl/sub_helpers/url.ts` (+3 -1) </details> ### 📄 Description Fixes #3109 ### Url is not properly parsed when importing using curl **Before** We were not respecting the `--location` parameter when parsing the curl request. **After** Respect the `--location` parameter when parsing the curl request. ### Body And Headers are not loaded properly **Before** In component `RequestOptions.vue`, we have a ref `request` which is set to `props.modelValue` in the setup function. but when the component updates with new props, this is not updated. this caused child components that uses this `request` ref to not get updated reactively. **After** Added a watcher that updates the `request` ref, when the props change. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>